Comments (13)
I do not oppose.
from desitarget.
Deleting the npyquery branches now. We need to contact Kaylan to talk about the dr2 branch. @forero could you please give us an update on the 'mocks' branch?
from desitarget.
This branch only includes a small script in bin/ to create target files from mocks.
That script should actually be in desisim/bin. Should I move it there and delete this branch?
from desitarget.
Creating target files from mocks sounds like it belongs under 'desitarget', not 'desisim'. Why should it be moved to desisim?
from desitarget.
A while ago @sbailey convinced me that if some code/script won't run on real data but only on simulated data, it should in principle go to desisim. That still sounds reasonable to me, but I agree that desitarget 'feels' like a natural place to have that script.
from desitarget.
Mocks are our best (simulated) real data, so I definitely think this code belongs here (i.e., in desitarget).
from desitarget.
Do we have a resolution to this question?
from desitarget.
@sbailey What do you think?
from desitarget.
I withdraw my knee-jerk reaction that desitarget must remain pure data with no code or knowledge of simulation / mock data.
OK for desitarget to have code for generating / organizing mock target data. Best if that is isolated within its own desitarget.mocks or similarly named submodule.
However, I will insist that the actual target selection code not know anything about mocks and not have secret back doors to the truth.
from desitarget.
So it sounds like we want to keep the 'mocks' branch. Beware though, it is now over 100 commits behind master, you'll definitely need to merge it with master before continuing to develop on it.
I'll keep this ticket open until we've confirmed a successful merge of master onto mocks.
from desitarget.
Right we'll keep it. I will merge it with master before continuing any other development.
@sbailey shouldn't we have here as well the script converting "martin's mocks" into target & truth files?
from desitarget.
Sure, that would be fine, instead of having it in fiberassign.
Stephen
from desitarget.
The 'mocks' branch is now active & up-to-date, & there is a separate issue, #48, for @kaylanb's branches.
from desitarget.
Related Issues (20)
- ragged array deprecation warning with numpy 1.20.3 HOT 3
- Override ledgers don't seem to be backwards-compatible with SV3 HOT 8
- test_mtl mid-z QSO test failure (intermittent?) HOT 6
- deprecated np.int and np.float HOT 1
- code to trace TARGETIDs back to original target files
- Ensure future secondary programs can't add bright objects to the ledgers
- Never let high priority TOOs for fiber overrides HOT 1
- Coverage of sv1, sv2, sv3 has dropped dramatically HOT 13
- Add "columns" option to desitarget.io.read_mtl_in_hp HOT 1
- Clean up unit tests and photutils dependency HOT 1
- Add sanity check that archiving is correct HOT 1
- Prevent override ledgers from recording negative numbers of observations HOT 1
- geomask.match(): check for duplicates HOT 3
- Y4 Y5 MWS program selection HOT 3
- main_cmx_or_sv() may incorrectly report 'main' instead of 'special' HOT 4
- Refactor setup.py installation method
- pkg_resources is deprecated HOT 1
- Include an option to read the MTLs using "ascii.ecsv" instead of "ascii.basic" HOT 1
- remove or fix desitarget.lyazcat
- select_targets can select north (south) targets for objects with south (north) photometry HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from desitarget.