GithubHelp home page GithubHelp logo

Comments (12)

maebeam avatar maebeam commented on August 14, 2024 1

@andyboyd let's start an email thread about how to make login with google and apple work well in mobile apps?

from identity.

maebeam avatar maebeam commented on August 14, 2024

Let's add ?google=false for now while we figure this stuff out.

from identity.

maebeam avatar maebeam commented on August 14, 2024

I added ?hideGoogle=true for now

from identity.

andyboyd avatar andyboyd commented on August 14, 2024

Thanks @maebeam, that's great as a stopgap solution. Happy to help you work on getting it working properly if you need it too.

from identity.

maebeam avatar maebeam commented on August 14, 2024

Well actually, with the change I pushed last night, it uses a redirect and should "just work" with a spoofed user agent. But I think the ideal solution is to figure out how to launch an ASWebAuthenticationSession.

from identity.

andyboyd avatar andyboyd commented on August 14, 2024

from identity.

maebeam avatar maebeam commented on August 14, 2024

Yes, it's absolutely time for a native library.

from identity.

andyboyd avatar andyboyd commented on August 14, 2024

@maebeam - it seems something has changed over the weekend, and now if hideGoogle=true is set, then there is no way to load a new account. If an account is already loaded into Identity, you can still log back into it, but you can't add another one. See the attached screenshot:

image

We'll need this to be fixed ASAP, no new users can sign up for our app with this issue, and existing users can't sign back in if they happen to have uninstalled.

from identity.

maebeam avatar maebeam commented on August 14, 2024

Apologies! Will push a fix now

from identity.

maebeam avatar maebeam commented on August 14, 2024

@andyboyd also, we changed the google flow to use a redirect instead of a pop up, so it should "just work" if you adjust the user agent accordingly

from identity.

andyboyd avatar andyboyd commented on August 14, 2024

Thanks @maebeam . Do you happen to know what the user agent needs to be set to in order to work in the google flow? I imagine it just needs to pretend to be Safari, though I'm not sure how good a practice it is to spoof the user agent to pretend to be something you're not. I could see it leading to some unintended consequences, but I'll have a play around and see if it works now.

from identity.

maebeam avatar maebeam commented on August 14, 2024

Yeah, just set it to any mobile safari UA. It should be totally fine.

from identity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.