Contextive LSP fails with unhandled exception about contextive

[chrissimon-au]

Thanks for the report! I had assumed that the LSP server library I was using would silently drop the window/showMessageRequest if the client doesn't support it (it does that with some other operations, such as workspace/configuration, but it seems I need to explicitly check for support.

Should be a fairly quick fix!

Thanks also for the info about configuring helix - I'll borrow that for the Contextive readme documentation if that's ok?

[ssiltanen]

Thanks also for the info about configuring helix - I'll borrow that for the Contextive readme documentation if that's ok?

Sure! I can report back once the LSP setup works if anything else was needed to set it up

[chrissimon-au]

Hi @ssiltanen v1.10.4 should resolve this issue - let me know how you go! As part of reproducing/testing, I've also added some documentation to the readme - let me know if this makes sense and works for you: https://github.com/dev-cycles/contextive#helix (note, it's basically yours, but you don't need the --stdio arg, and I've included what to do if the definitions file is not in the default location.

As a helix user, you might also be interested in this discussion: helix-editor/helix#8850 - about using an LSP on all files. If they describe how to do that, or decide to update helix to support it, I'll update the documentation.

It also seems that I could open a PR against https://github.com/helix-editor/helix/blob/master/languages.toml to make the language-server configuration 'baked into' helix - it would then just require the user to nominate which languages to enable it for. I'll wait until the discussion above is resolved before doing that, though, to ensure I understand the intended approach for an lsp like this.

Feel free to raise another issue if any problems!

[chrissimon-au]

Hold on that, seems to be an issue with 1.10.4. Will be getting a fix out shortly.

[chrissimon-au]

OK 1.10.5 should work.

[ssiltanen]

OK 1.10.5 should work.

Yes, it resolves the issue (v.1.10.5)! Thank you for work 💯

I've also added some documentation to the readme

Documentation looks correct to me and I can verify the --stdio was not needed after all like you mentioned. Although, in my configuration I did not specify the definitions.yml path but instead created it under .contextive in the repo root and let the LSP find it on its own.

discussion about using an LSP on all files

Thank you, I was not aware of that discussion taking place yet, but that would be indeed cool to have, especially with this LSP. I agree before creating the helix PR, it is wise to follow the discussion you mentioned.

Also, this might be just a user error on my behalf but I noticed a behaviour with Helix and multi LSPs that the onHover shows docs only of one LSP, which affects Contextive as well. I started a discussion about it here helix-editor/helix#8872

[chrissimon-au]

Great, thanks for confirming! And thanks for opening that discussion - I'll keep an eye on that as well, as it is almost always the case that Contextive is used alongside another language server.