GithubHelp home page GithubHelp logo

Comments (21)

sirinoks avatar sirinoks commented on August 23, 2024 3

Done in 6a89e35
Thank you for an opportunity!

from devprotocol.xyz.

vinzvinci avatar vinzvinci commented on August 23, 2024 2

hashub

miraise

monexventures

msstartups

sios

here you go.

from devprotocol.xyz.

vinzvinci avatar vinzvinci commented on August 23, 2024 1

I think it better to follow the background color here to fix this issue

image

from devprotocol.xyz.

gptkrsh avatar gptkrsh commented on August 23, 2024

Good First Issue

This looks something that can be fixed by first time contributors to this repository. If you have already made a contribution to this project, please reserve this issue for a new contributor.

Here are the steps to resolve this issue:

  • Find the files uploaded to this issue's comments
  • Replace them with the current images
  • Open a PR

If you have any questions about how to resolve this issue, or about the contributing process in general, feel free to ask us.

from devprotocol.xyz.

sirinoks avatar sirinoks commented on August 23, 2024

I'm not sure what the actual issue is. Is it that Monex Ventures supposed to have a black background, or every image with a black backgroud should have a transparent one?

from devprotocol.xyz.

gptkrsh avatar gptkrsh commented on August 23, 2024

@sirinoks, @vinzvinci is gonna upload some files here soon, you just gotta replace the existing files in the public/assets dir with the new ones

from devprotocol.xyz.

sirinoks avatar sirinoks commented on August 23, 2024

Oh, lol, okay. It's barely any work at all :o

from devprotocol.xyz.

gptkrsh avatar gptkrsh commented on August 23, 2024

@sirinoks Do you want to work on this? I'll assign you 🙂

from devprotocol.xyz.

sirinoks avatar sirinoks commented on August 23, 2024

@krishguptadev Yes!

from devprotocol.xyz.

vinzvinci avatar vinzvinci commented on August 23, 2024

https://www.figma.com/file/rmCKKIsjSWCH0q6lObDQC8/Dev-Protocol-design?node-id=0%3A1

Hi, do u think it is possible to get the image here @sirinoks? As of now, I don't have their files.

from devprotocol.xyz.

gptkrsh avatar gptkrsh commented on August 23, 2024

@vinzvinci I could get these images correctly from the file:

monexventures
msstartups

from devprotocol.xyz.

gptkrsh avatar gptkrsh commented on August 23, 2024

I think it better to follow the background color here to fix this issue

image

I applied the color that was present in the design, ie light gray not sure what could we change more?

from devprotocol.xyz.

vinzvinci avatar vinzvinci commented on August 23, 2024

Wdym?

I think it didn't apply yet. The bg shows black. Pls change it to #E5E5E5

from devprotocol.xyz.

gptkrsh avatar gptkrsh commented on August 23, 2024

Idt that tailwind styles don't apply: https://github.com/web3community/devprotocol.xyz/blob/main/src/pages/index.astro#L63

from devprotocol.xyz.

vinzvinci avatar vinzvinci commented on August 23, 2024

How about bg-gray-200?

from devprotocol.xyz.

gptkrsh avatar gptkrsh commented on August 23, 2024

How about bg-gray-200?

Doesn't make a change, All images have that black bg... afaik

from devprotocol.xyz.

vinzvinci avatar vinzvinci commented on August 23, 2024

That's weird, try to use a white background for awhile.

from devprotocol.xyz.

gptkrsh avatar gptkrsh commented on August 23, 2024

That's weird, try to use a white background for awhile.

For testing purposes I have edited the html inside the browser, check this. It doesn't affect the stuff since the images possess the dark gray bg, the section doesn't:
image

from devprotocol.xyz.

vinzvinci avatar vinzvinci commented on August 23, 2024

Thanks for checking @krishguptadev. Photoshop can do this xD.

from devprotocol.xyz.

shuklaritvik06 avatar shuklaritvik06 commented on August 23, 2024

Done in 6a89e35
Thank you for an opportunity!

Great! Thank you for your contribution ✨

from devprotocol.xyz.

vinzvinci avatar vinzvinci commented on August 23, 2024

Please check #30 (comment)

from devprotocol.xyz.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.