Comments (4)
No need to apologize! I've started a list of best practices, which includes this slice
technique, here #45
from react-virtual-list.
Main script will be fixed in the next release! I'll look into supporting mobx lists (possibly a shape with map
).
Edit: please see version 2.2.0
from react-virtual-list.
I have no experience with mobx, but after doing some quick research, it looks like there are may be two options:
Change
PropTypes.array.isRequired
to
PropTypes.shape({
map: PropTypes.func.isRequired,
length: PropTypes.number.isRequired,
})
or
Instruct mobx users to use slice
on their arrays before using them in this component. From the mobx documentation on arrays:
Bear in mind however that Array.isArray(observable([])) will yield false, so whenever you need to pass an observable array to an external library, it is a good idea to create a shallow copy before passing it to other libraries or built-in functions (which is good practice anyway) by using array.slice(). In other words, Array.isArray(observable([]).slice()) will yield true.
@uinz - as a mobx dev, do you have any thoughts on which makes more sense?
from react-virtual-list.
sorry, I am unskilled with mobx
I think use .slice()
to avoid type inspection error is the right way
from react-virtual-list.
Related Issues (20)
- throttleWithRAF causes setState warning
- Added elements is not render HOT 1
- Load in items? HOT 1
- Is it possible to set containerHeight 100% instead of a fixed size? HOT 2
- [SSR] During server render, window object is not defined. HOT 1
- Check state HOT 1
- Support cordova/phonegap HOT 2
- mobx observable and checking items against PropTypes.array HOT 1
- 1,000,000 record can't render HOT 1
- React 16 Support HOT 4
- The built version (in lib directory) is out of sync with sources HOT 1
- Proposal: switch from HoC to render prop (or function as children) HOT 10
- Table with scrollable tbody example HOT 1
- Error: Uncaught TypeError: Cannot read property 'firstItemIndex' of undefined HOT 2
- Feature: dynamical height of items HOT 2
- Feature: simulate body scroll on mobile browsers
- Please add types for typescript
- Is this supported for react "^16.13.1" as well?
- Restore scroll position on navigation
- react hooks rewrite HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-virtual-list.