Comments (7)
But wouldn't it be more beneficial to have speaking variable names instead?
Comments can be valuable, but should focus more on the Why instead of What, therefore the code itself should be better understandable in the what part.
Unless there was a need to win in a code golfing competition, there shouldn't be a need for single letter variables anyway.
from greenlet.
Someone already annotated it:
https://news.ycombinator.com/item?id=16258172
https://gist.github.com/zz85/25564f1910f1877c39c25ace5e5159bc
from greenlet.
@developit sure, go ahead with it!
the single letter variables look rather cryptic at first and could be better named, but it was also fun trying to understand what it was doing. knowing a little about promises, web workers and javascript helped too i guess :)
from greenlet.
I love the idea of comments annotating things!
from greenlet.
Yup!
from greenlet.
Hey @zz85 - mind if I add some of your annotations to the library itself?
from greenlet.
Should be much more readable now.
from greenlet.
Related Issues (20)
- Support for terminating workers? HOT 5
- Edge issue. SCRIPT5022: SecurityError HOT 4
- Generator functions HOT 4
- Uncaught SyntaxError: Unexpected identifier in Chrome 69 HOT 6
- Pass data in to function HOT 1
- indexedDB is null in Firefox HOT 1
- _ref not defined in Create react app. HOT 4
- Cannot find module 'greenlet'. ts(2307) HOT 1
- Make greenlet working with a pool of Promises HOT 2
- Synchronous functions broken in TypeScript
- __awaiter is not defined HOT 3
- v1.1.0 does not respect semantic versioning IMHO
- Releasing thread and URL reference when the workerized function is not needed HOT 1
- <frozen importlib._bootstrap>:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144 from C header, got 152 from PyObject
- Why do I get a return of undefined? HOT 3
- Cannot use greenlet in node. TypeError: URL.createObjectURL is not a function HOT 1
- Cannot use spread operator HOT 1
- ESLint/TypeScript: Any way to mark the function as external/scope-less?
- _ref is not defined
- support module workers?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from greenlet.