Comments (5)
Sure @khoran! I try to add it asap ;)
from dfp_external_storage.
Hi again @khoran just made some fixes and added the feature within this commit in "develop" branch (ddea16c) could you check it at your side please? Here you are one of my external storage settings with new field "Doctypes ignored for file attachments":
Please give me feedback and then I will publish to both production branches "version-14" and "version-15".
Thanks for everything @khoran :)
from dfp_external_storage.
That works great, thank you! I wonder though if you should include the doctypes you list as examples as default values. The Repost Item Valuation failure is easy to miss because it happens in a background work queue. Even when noticed, the error message would not immediately lead one to this plugin and adding it to the ignored set. The consequence of these reposts not running is that all your stock values are off, which is pretty bad (auditors will be unhappy!).
from dfp_external_storage.
Thank you @khoran !! You are totally right. That doctype is not within default Frappe app, it is an ERPNext one, so we should check for that app before... and add them on demand automatically when creating a new external storage. I will think about it and maybe I can stole some hours this weekend ;)
from dfp_external_storage.
Hi @khoran as we talked previously, I just added by default both Frappe doctypes affected for new External Storages (ba3f7d3). For ERPNext doctypes we should check if app is installed before add them (I invite you or @MrJico to add those lines and create a pull request :).
from dfp_external_storage.
Related Issues (19)
- Fails when an existent file is uploaded HOT 1
- DocType Permissions HOT 1
- accessing propery on self.dfp_external_storage_doc when it is None HOT 1
- files in cloud are opening in browser instead of downloading HOT 6
- file_url base is "file" instead of "files" HOT 8
- Feature: allow streaming file content directly to S3 HOT 2
- When simulating file losts on bucket images show 404 error HOT 2
- Waiting for collaborator to test for removed lines HOT 1
- import problem HOT 2
- ERPNext Report not working due to call of get_content on file in S3 HOT 4
- streamed downloads HOT 6
- a few tweaks to recent streaming changes HOT 4
- attachment shearing not working HOT 17
- URL must start with http:// or https:// HOT 1
- duplicate file names HOT 8
- Error generating Prepared Report HOT 4
- Unable to Upload Files If no storages are defined
- Nonetype has no attribute list object or put_object HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dfp_external_storage.