Comments (3)
Hello @mmatuk,
We refactored our code to follow our documentation. The sortingEnabled property should always be specified and should not be null
or undefined
according to the following help topic: SortingState.ColumnExtension. Could you clarify if it's critical for your project to use the old logic?
from devextreme-reactive.
Thank you getting back to me. We have a wrapper component around the SortingState that always injects a sortingEnabled value that matches the default sortingEnabled flag into the passed columnExtenstions array. This fixes the issue for us. In my opinion, though, it makes more sense to not require sortingEnabled flag for every column if you only want it enabled for one or two columns. The individual column config should allow overriding the default sortingEnabled flag and if not defined then it should fallback to the default. The current behavior does not do this. If you forget to add a sortingEnabled flag, even if it matches the default, you get some unexpected behavior as seen in the example above.
Your current documentation also does not indicate that if you add the sortingEnabled flag for even one column, then you must add it for every column even if it matches the columnSortingEnabled flag.
from devextreme-reactive.
Hello @mmatuk,
In our documentation, we add ?
after property names that can be null/undefined. You can see examples here: https://devexpress.github.io/devextreme-reactive/react/grid/docs/reference/sorting-state/#properties. The sortingEnabled
property in SortingState.ColumnExtension
does not have ?
, which means that it should be explicitly defined.
In any case, we appreciate your feedback and we'll consider adding a default value to the sortingEnabled property.
from devextreme-reactive.
Related Issues (20)
- Warning: Failed prop type: The prop `groups` is marked as required in `HorizontalLayout`, but its value is `undefined`. at HorizontalLayout HOT 1
- Warning: Failed prop type: The prop `currentView.displayName` is marked as required in `Memo`, but its value is `undefined`. HOT 1
- Scheduler - some appointments are hidden by overlapping elements HOT 3
- Fixed row in DevExtremeREACTIVE HOT 1
- Colspan misalignement problem using groups and action custom columns HOT 1
- EditRecurrenceMenu doesn't show before onCommitChanges function is called HOT 2
- Support for ExcelJS version 4 HOT 1
- Certain styling broken by DX's migration to MUI v5 HOT 1
- rrule import (scheduler-core) error seems still to exist HOT 8
- (@mui/x-date-pickers: 6.0.3 compatible) TypeError: date.isBefore is not a function HOT 5
- Recurring event not handling daylight saving time HOT 2
- Change Layout For TimeScale in DayView's mode HOT 2
- Show week number in scheduler HOT 1
- A dependency not working HOT 2
- Jerky scrolling with variable row heights in Virtual table HOT 2
- Empty Table header HOT 1
- Scheduler not fitting parent container HOT 2
- Need the right side layout of Appointment Form model. HOT 2
- Unexpected jump to top when scrolling down after Edge restart HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from devextreme-reactive.