Comments (14)
interesting, I will investigate in the next couple days. I have been launching 3.x a little ahead of schedule because 2.x started to break, and frantically fixing things today, lol. I trade on GDAX so that is where my code starts, but I will go back and update bitfinex / poloniex plugins next, based on 3.1 which I released today.
Cheers,
Carlos
from zenbot.
Thanks for the prompt response. You've been committing like a mad-man! Mad respect. I am excited to watch this project grow and I will let you know if I find anything else of interest.
from zenbot.
@JFD3D hello there,
The pull is not complete yet* please don't use it yet... still work in progress till the Poloniex exchange is fixed. I am currently adding them so @carlos8f has less fingerbleed from writing all those crypto coins.
Yours Faithfully,
RDash
from zenbot.
Hello @RDash21, looks like your pull request just got merged :)
That makes sense. I noticed that your settings for "min_size", "max_size", and "increment" are much different than what I have. Have you been able to get any BTC pair to graph properly yet? Oh and it looks like ETC is in there 3 times in a row.
Also @carlos8,f I noticed the max size for ETH is 100000 as opposed to 10000 for other coins in your gdax exchange.js. Is this due to volume or because of the price difference?
Thanks,
JFD3D
from zenbot.
Thanks for the find on the ETC! Going to update it now 👍
Probably an error on my side for not seeing it (Hence for being uncle and having a 11 Months niece!)
Going to fix it asap!
from zenbot.
@RDash21 Also USDT pairs are missing, I have these:
{
"id":"USDT_BTC",
"asset":"BTC",
"currency":"USD",
"min_size":0.01,
"max_size":10000,
"increment":0.01,
"label":"USDT/BTC"
},
{
"id":"USDT_DASH",
"asset":"DASH",
"currency":"USD",
"min_size":0.01,
"max_size":100000,
"increment":0.01,
"label":"DASH/USD"
},
{
"id":"USDT_ETC",
"asset":"ETC",
"currency":"USD",
"min_size":0.01,
"max_size":10000,
"increment":0.00001,
"label":"ETC/USD"
},
{
"id":"USDT_ETH",
"asset":"ETH",
"currency":"USD",
"min_size":0.01,
"max_size":100000,
"increment":0.01,
"label":"ETH/USD"
},
{
"id":"USDT_LTC",
"asset":"LTC",
"currency":"USD",
"min_size":0.01,
"max_size":10000,
"increment":0.01,
"label":"LTC/USD"
},
Not sure if ETC needs "increment":0.00001,
as opposed to "increment":0.01,
or another value entirely but it looks like it's working. This might make it more accurate but I haven't had the time to dig through and figure out how the graph and zenbrain uses these values. Also you should remove the comma at the end of the list as it causes zenbrain to throw an error since it is expecting more pairs. Hope this helps.
from zenbot.
I am aware that Poloniex USDT Currencies are missing and also quite some other crypto coins. Still working on adding them all which is a HUGE list. Poloniex does accept 0.0001 on most currencies and some requires 0.01 for trading. hopefully @carlos8f got some good feedback regarding that?.
@carlos8f what do you think of doing as 'minimal' trade?
Yours Faithfully,
RDash
from zenbot.
Oh and you need to add BTC as a "currency" in config.js and switch asset and currency in polo's exchange.js, for example:
"asset":"ETC",
"currency":"BTC",
Otherwise it will not work at all.
from zenbot.
@JFD3D thanks for noticing, fixing it tonight :)
from zenbot.
@JFD3D looks like I got to work on it as soon as possible. It will be fixed by tonight including USDT will be added. Thank you for noticing :)
from zenbot.
Working on it... check out PR #23 (Note: it is still work in progress.. 👍 )
from zenbot.
ok, as of now zenbot master branch has working poloniex, kraken, and bitfinex code. see https://zenbot.s8f.org/ for some new exchange/pair graphs including ETH, LTC and EUR.
from zenbot.
also note that bitfinex doesn't have a backfill API, so we can't pull historical trades to populate the graph.
from zenbot.
After a lot of digging around I found the problem and fixed the Altcoin Graph's :)
The issue was in plugins/server/controllers/data.js where the data was being written with too few decimals causing the graphs to have no open/close data to read from for anything with a sub 0.01 value. This is why the candlesticks/indicators weren't showing up properly even though the trade arrows were on the accurate price.
from zenbot.
Related Issues (20)
- Coinbase Pro (gdax) maker/taker fees much higher for low volume trading
- Implenting genetic backtesting HOT 1
- Installation failure with ubuntu 20.04 HOT 2
- Error with docker-compose on windows HOT 6
- Binance API is down! unable to call getBalance, retrying in 20s HOT 1
- kraken: order buy XETH-ZEUR and XXRP-ZEUR HOT 1
- if (!match) throw new Error('invalid bucket size spec: ' + spec); HOT 1
- Crash when unable to get the account balance. HOT 3
- Thoughts on backfills based on trade history
- Forex.analytics npm install error Node 16.4.1
- Issue with docker: Error: listen EADDRINUSE: address already in use :::17365 HOT 2
- deviavir/zenbot docker image 10 month old HOT 7
- just posting a fix for anyone that might have the "MongoNetworkTimeoutError" i was having.....
- Feature: AI or brute force to detect the best strategy and parameters HOT 3
- Unexpected token * HOT 4
- Zenbot hanging HOT 5
- Buy_hold is always wrong
- Huge speedup HOT 7
- Zenbot notifications
- Enable web interface before data load,
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zenbot.