GithubHelp home page GithubHelp logo

[BUG]: Plain icons return 403 about devicon HOT 7 OPEN

jeremygau avatar jeremygau commented on May 29, 2024 3
[BUG]: Plain icons return 403

from devicon.

Comments (7)

lunatic-fox avatar lunatic-fox commented on May 29, 2024 2

As @jeremygau said it's not a breaking change (with some exceptions), however it's a feature that can be implemented to the project. I mean, since we have aliases to an icon it could fallback to the base icon or to a default icon.

One way that comes to my mind to solve this issue, like the case that @BalaM314 presented, is serving icons by an API. In other words, I could make another API like deviconapi that inherits the functionalities of the current one (which I prefer) or make big changes directly into deviconapi (which can possibly include some breaking changes).

The safest way to use the icons by now is using the devicon.dev site references.

That's weird but I think aliases weren't properly used at all in the project, just like tags.

from devicon.

Snailedlt avatar Snailedlt commented on May 29, 2024 1

Hi there, thank you for reporting this!
This was not intended, and not expected, especially for icons like react, where the icon itself hasn't been removed or changed. It seems like something might have gone wrong with some aliases in the latest release.

@lunatic-fox do you have time to take a look at this ASAP?

from devicon.

jeremygau avatar jeremygau commented on May 29, 2024 1

I don't think that these icons have ever existed in plain version.
For those that I am talking about, it is not a breaking change. I started to use them yesterday.

Perhaps I should not have report that as a bug
But as a request icon

The 403 error code misleaded me

from devicon.

BalaM314 avatar BalaM314 commented on May 29, 2024 1

1a35e2b this commit deletes the -plain version for Rust, the -plain icons did exist before

from devicon.

BalaM314 avatar BalaM314 commented on May 29, 2024

Same issue
There are probably many sites relying on this repo for images, and that commit just broke all of them with no warning
please add back the -plain icons

from devicon.

Panquesito7 avatar Panquesito7 commented on May 29, 2024

I'm using the https://cdn.jsdelivr.net/gh/devicons/devicon@latest/icons/devicon/devicon-plain.svg like urls

I'm kind of confused now. 🤔

The file react-plain.svg itself does not exist, and if you try to access it directly, it won't work.
If you try to access that file even in the previous version (which had the icons working fine I believe), it won't work: https://cdn.jsdelivr.net/gh/devicons/[email protected]/icons/react/react-plain.svg

from devicon.

Panquesito7 avatar Panquesito7 commented on May 29, 2024

Perhaps I should not have report that as a bug
But as a request icon

AFAIK, the icons you mentioned have aliases on other versions such as plain. See, for example, the react icon.

devicon/devicon.json

Lines 8624 to 8633 in 6910f05

"aliases": [
{
"base": "original",
"alias": "plain"
},
{
"base": "original-wordmark",
"alias": "plain-wordmark"
}
]

from devicon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.