GithubHelp home page GithubHelp logo

Comments (9)

jevalenciap avatar jevalenciap commented on June 15, 2024 1

Thank you so much! It's working fine now

from action-format-hcl.

jevalenciap avatar jevalenciap commented on June 15, 2024 1

Thanks @ChristophShyper, I don't know why it was failing but after removing a couple of files that were not longer needed, it's working fine.
Apologies for the inconveniences.

from action-format-hcl.

ChristophShyper avatar ChristophShyper commented on June 15, 2024

Hello, thank you for using my action!

I'll have a look at it.
Maybe already I'll replace using those scripts with simply using Terragrunt, as it finally can format all .hcl and .tf files.

from action-format-hcl.

ChristophShyper avatar ChristophShyper commented on June 15, 2024

I've released v0.3.5 which should resolve the problem.
image

I also checked terragrunt hclfmt, but it just fixes the files without any options that terraform fmt has. But it's much faster, so maybe I'll consider it in the future as an option if somebody has a lot of files.

from action-format-hcl.

jevalenciap avatar jevalenciap commented on June 15, 2024

Thanks @ChristophShyper for your prompt response and action. I have a question:
I need it fails in case it find an error in the linting process. I thought using check input it fails but not.
Do you know how can achieve that goal?
See screenshot
error_no_fail

from action-format-hcl.

ChristophShyper avatar ChristophShyper commented on June 15, 2024

Hello @jevalenciap .
You're right I recently removed set -e from the dependent script it stopped failing on the first type of files.
But now I fixed it in origin and released v0.3.6 version where it's fixed, as I just tested.

from action-format-hcl.

jevalenciap avatar jevalenciap commented on June 15, 2024

Hello @ChristophShyper,

Sorry, but now the github action is always failing despite there are not linting errors:

failing_linter

I think it needs to fail once a linting error is found but not when there are not errors found.

May you please apply a fix?

Thanks in advance!

from action-format-hcl.

ChristophShyper avatar ChristophShyper commented on June 15, 2024

hi @jevalenciap I've tested it on all 4 possible scenarios and all work well for me.
Are you sure all your files are formatted properly?

from action-format-hcl.

ChristophShyper avatar ChristophShyper commented on June 15, 2024

@jevalenciap No need to apologize. Thanks to you, I noticed an error in the script being used here.

from action-format-hcl.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.