Comments (5)
This only comes up when using minified es6. @pachonk care to test this out?
from snuggsi.
from snuggsi.
@pachonk check out the dist
readme. It's in the minification
step. Converting es6 to es5. I think our polyfill uses the same minifier thus creating the same tiny variable names e
.
We use this https://github.com/paulovieira/UglifyJS2
from snuggsi.
@pachonk to be clear i don't know what that first error is. That should cure half your queries.
from snuggsi.
@angelocordon @robcole @brandondees come to find out this was a bug in Safari. They have recently fixed it and is in current preview of Safari 11 (releasing in September). This is a good thing but requires someone to be forced to update. This bug still lingers for many people on safari who haven't updated. This is a perfect example of by leaning on the specs since they are "living" not every browser will always be at 100%. That being said the onus is on the PLATFORM VENDOR not the developer to update as in this case. The problem is happening when we minify ES6 -> ES6(minified with UglifyJS). I'll get this fixed up after I do a little research on the references. Luckily we have an unminified version that works fine and can use that in the mean time for Safari support. Thus (temporarily) fixing the initial issue @angelocordon and I first discovered.
Reference Links
- UglifyJS issue - mishoo/UglifyJS#1753
- UglifyJS Pull Request - mishoo/UglifyJS#1851
- Webkit Bug - https://bugs.webkit.org/show_bug.cgi?id=171041
- Webkit changeset - https://trac.webkit.org/changeset/217200/webkit
- Glimmer (Ember.js) - github.com/glimmerjs/glimmer-blueprint/issues/58
- Glimmer (Ember.js) - github.com/glimmerjs/glimmer-application-pipeline/issues/123
Fix for UglifyJS
safari10: true
https://github.com/mishoo/UglifyJS2/tree/harmony#mangle-options
Problematic UglifyJS Output
If you notice below the .assign (e, ...)
is being shadowed by let e
later within the function. The ECMAScript language has no issue with shadowing variables (We do this with Element
vs window.Element
)
from snuggsi.
Related Issues (20)
- Shrink NPM Package Size HOT 2
- Setup Zeit.co now 2.0 HOT 1
- Getter not updating template value after set HOT 2
- Polyfill support for IE11+ HOT 4
- Update Documentation for `context`, `initialize`, `onconnect`, & `onidle`
- nested templates HOT 5
- devDependencies SECURITY ALERT
- browser-sync -> localtunnel -> axios vulnerability
- Sponsorship button
- `<template>.content` May not be working in I.E. 11 after `DomContentLoaded`
- Remove Web Components Section from Readme.md
- Declarative properties
- Range node error when parsing Template tokens. HOT 6
- Incommunicado? HOT 6
- Slack link not working HOT 1
- What is the reason for the limited npm/node engines? HOT 3
- Browser Sync vulnerability ... (again) HOT 6
- Basic example: Getting "TypeError: Illegal constructor" HOT 7
- Is it possible to tweak to be able to run on Android 4.4 KitKat? HOT 1
- "Failed to execute 'selectNodeContents'" on 'Range': parameter 1 is not of type 'Node' HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from snuggsi.