GithubHelp home page GithubHelp logo

Comments (6)

ggreif avatar ggreif commented on July 30, 2024

To give a concrete example, this Motoko

func upperMask(a : Word8) : Bool = a & (0x80 : Word8) != (0 : Word8);

compiles currently to this Wasm:

  (func $upperMask (type 5) (param $clos i32) (param $a i32) (result i32)
    local.get $a
    i32.const -2147483648 // 0x80000000
    i32.and
    i32.eqz
    i32.eqz
    i32.const 1
    i32.shl)

We could have (unverified)

  (func $upperMask (type 5) (param $clos i32) (param $a i32) (result i32)
    local.get $a
    i32.const 31
    i32.shr
    i32.const 1
    i32.shl)

from motoko-base.

ggreif avatar ggreif commented on July 30, 2024

Something like

func upperBitGe(a : Word8) : Bool = a >= (0x80 : Word8);
func upperBitGt(a : Word8) : Bool = a > (0x7F : Word8);

with upperBitGt will likely not work out of the box:

  (func $upperBitGt (type 5) (param $clos i32) (param $a i32) (result i32)
    local.get $a
    i32.const 2130706432 // 0x7f000000
    i32.gt_u
    i32.const 1
    i32.shl)
  (func $upperBitGe (type 5) (param $clos i32) (param $a i32) (result i32)
    local.get $a
    i32.const -2147483648 // 0x80000000
    i32.ge_u
    i32.const 1
    i32.shl)

unless we insert redundant hint instructions into the Wasm:

  (func $upperBitGt (type 5) (param $clos i32) (param $a i32) (result i32)
    local.get $a
    hint (i32.const 0xFF000000; i32.and) -- adds some info about the TOS: 24 lower bits are zeroed
    i32.const 2130706432 // 0x7f000000
    i32.gt_u
    i32.const 1
    i32.shl)

With such hints we can perform the i32.const 31; i32.shr trick.

I envision the hint meta-instruction (never emitted) to operate on top-of-stack asserting a semantic nop. This part is probably not beginner-friendly, though.

from motoko-base.

ggreif avatar ggreif commented on July 30, 2024

eqz; eqz; if --> if this is already performing: double swapping of the if legs.

from motoko-base.

ggreif avatar ggreif commented on July 30, 2024

Also note that after a 1-bit masking shr 31; shl 1 is just shr 30. Free tagging! Of course that is a different optimisation, since it needs the and to be preserved.

from motoko-base.

ggreif avatar ggreif commented on July 30, 2024

See motoko/gabor/peephole-177 for an implementation sketch (very WIP).

from motoko-base.

ggreif avatar ggreif commented on July 30, 2024

Another reduction path:

    block (result i32)  ;; label = @1
      i32.const 1
    end
    drop

block --> const --> eliminated by drop

from motoko-base.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.