GithubHelp home page GithubHelp logo

[RFC] DidUri improvements about did HOT 4 OPEN

dhuseby avatar dhuseby commented on August 17, 2024
[RFC] DidUri improvements

from did.

Comments (4)

dhuseby avatar dhuseby commented on August 17, 2024

Hrm...if we make the trait called DidUri instead of Did, then we can have a module level method that does the parsing and tries to create instances of the method-specific types that impl the DidUri trait. That way we could just do this:

// this will create an instance of DidGitUri
let git = Did::from_str("did:git:akjsdhgaksdjhgasdkgh").unwrap();

// this will create an instance of DidSovUri
let sov = Did::from_str("did:sov:akjsdhgaksdjhgasdkgh").unwrap();

That's what I'm thinking.

from did.

mikelodder7 avatar mikelodder7 commented on August 17, 2024

My only concern is that all DIDs have a common format which is the goal of this function. After generic parsing, then you can downcast to the most specific ones, so Iā€™m not sure what the trait buys.

from did.

mikelodder7 avatar mikelodder7 commented on August 17, 2024

Iā€™m not opposed to having a generic parse that returns the specific instance

from did.

dhuseby avatar dhuseby commented on August 17, 2024

My only concern is that all DIDs have a common format which is the goal of this function. After generic parsing, then you can downcast to the most specific ones, so Iā€™m not sure what the trait buys.

I guess that does make more sense. I'm mostly concerned with turning the method specific parts of the DID into instances of objects for that method. for instance, turning the commit hash in a did:git string into a commit object from libgit2.

from did.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.