GithubHelp home page GithubHelp logo

Error on game start after just installing the addon: DialogicGameHandler.gd: Node not found: "Inputs" and "Portraits" (relative to "/root/Dialogic") about dialogic HOT 2 CLOSED

hsandt avatar hsandt commented on June 2, 2024
Error on game start after just installing the addon: DialogicGameHandler.gd: Node not found: "Inputs" and "Portraits" (relative to "/root/Dialogic")

from dialogic.

Comments (2)

Jowan-Spooner avatar Jowan-Spooner commented on June 2, 2024

Thanks! This has been reported on discord recently too, I'll try to push a fix. We should call these in post_install() instead of ready, which works like the second option you suggested.

from dialogic.

hsandt avatar hsandt commented on June 2, 2024

Thanks! This has been reported on discord recently too, I'll try to push a fix. We should call these in post_install() instead of ready, which works like the second option you suggested.

Yes, I just found post_install in the meantime and moved both collect methods there:

collect_text_effects()
collect_text_modifiers()

The second one, collect_text_modifiers(), may not trigger a bug right now, but it may later if we add a node-based modifier, so this looks safer and more consistent.

Result:

func post_install():
	dialogic.Settings.connect_to_change('text_speed', _update_user_speed)
	collect_text_effects()
	collect_text_modifiers()

func _ready():
	collect_character_names()
	dialogic.event_handled.connect(hide_next_indicators)

So it works with this workaround, and should make an easy PR! (but you can also check all occurrences of get_node in _ready methods too, if there are any)

I'm not on the Discord but I'll be notified if you update this issue.

from dialogic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.