Logging Review about aries-cloudcontroller-python

[morrieinmaas]

Hey, yeah we should remove this print statement I think. Generally right now all logs to console out. If we want to log to a file instead we have to set that up. If we want to do that we need to agree on whether we want everything to be logged into a single file or whether we possibly want different files/logs for different things. Any thoughts on that?

We also need to decide whether we want to go with the default log level WARNING or whether we want to change that to eg INFO.

We should also consider setting a switch for DEBUG mode so if the the controller is used in DEBUG mode DEBUG things will be logged.

[morrieinmaas]

Also I did introduce testing that certain events get logged in the unit tests that got merged in. So like I said, I think we need to agree on how we want to log to file for instance and what that file is called, log level etc...

[morrieinmaas]

I reckon the logging is ok now. I also changed the logger name space to be generic (name) so it gets picked up properly. If I'm not mistaken the way logging should be approached with the controller is:

• When using the controller in a bigger context like in a jupyter notebook the messages get picked up via the logger in jupyter. Since that default log level is warning I htink and we have quite a few info level logging events only warning or higher will be spat out by jupyter. This can be managed by setting the logger in the notebook
  import logging
logging.basicConfig(level=logging.INFO)
  or passing that as startup param to jupyter. One can see jupyter logs by right-clicking in the notebook and selecting Show Log Console.
• generally the logs go to stderror.
• It's also possible to specify a file to log to. I reckon the application using the AAC will set/specify that?! We coud also implement such thing in the controller itself...

[wip-abramson]

Cool, yep its an application thing. We just should know how to handle it and ideally document it somewhere.

We will definitely want to enable it for the simplified API work.

[TimoGlastra]

As this library only passes through data I don't think this is applicable anymore, please reopen if that's not the case