Comments (14)
Thanks. Fixed.
from dosage.
Can you test it?
from dosage.
Is this still working? When I run with the LC_ALL=tr_TR
I still get Sunday as the first day
from dosage.
from dosage.
Yeah, I have no idea how to reliably get the first day of the week. If you know how, please let me know.
from dosage.
I see two examples that seems the same or similar.
https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/src/shell-util.c?ref_type=heads#L79-135
from dosage.
From Evolution
from dosage.
I understand very little of this code. The calculation seems to be correct (I think..)
The problem is figuring it out the week number of the current locale (I'm using 1, October 2000) this day for me is on week 40, for you it should be week 39.
It's always gives 40 as the result now, before it gave 39 when I changed the locale, I didn't change anything in the code and somehow it stopped working so ¯_(ツ)_/¯
from dosage.
Could you use different date. E.g: 1, October 2017. Turkish timezone and daylight saving changed around 2016.
from dosage.
I could try to tackle this.
from dosage.
Could you use different date. E.g: 1, October 2017. Turkish timezone and daylight saving changed around 2016.
Doesn't seem to make a difference.
I could try to tackle this.
@erklyn That's the function:
Lines 15 to 24 in 66b505d
If you manage to fix it, please open a PR.
Also make sure to backup your data before running the latest commit, I change some stuff and I didn't test everything properly yet, so it may cause some data loss.
from dosage.
@diegopvlk looks fine and works fine on my system as well, returns 39 for me I am an in Turkey so works correctly.
there might be an issue on the button part. I'll take a look as soon as possible and post a pr.
from dosage.
@erklyn It's not the button, you can test it by just returning false instead.
What's your output of locale
?
from dosage.
Turns out there is a very simple command to check the first weekday: locale first_weekday
🤦♂️
from dosage.
Related Issues (20)
- can't edit treatment HOT 1
- Better screenshots HOT 2
- idea: Health reminders HOT 2
- Modify Scheduled Dosages in-place [FEATURE] HOT 3
- 📱 Mobile App Version (computer / mobile sync) HOT 15
- Export functionality HOT 1
- Feature: Clear history older then x days HOT 2
- Feature: Allow disabling autostart HOT 5
- Repeated notifications/reminders HOT 1
- Android/ios app? HOT 2
- cannot choose a white colour HOT 1
- No localization at all HOT 9
- Treatements apparently only appear in Today tab if lastTaken is null... HOT 16
- Option to group notifications for meds taken at the same time HOT 3
- Sync program data through Nextcloud HOT 5
- Notifications on GNOME 46 HOT 3
- No monthly prescriptions support HOT 2
- Some of my German translations have vanished HOT 3
- Dosage not respecting dosage end date HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dosage.