GithubHelp home page GithubHelp logo

non virtual destructor about tinyfsm HOT 3 OPEN

digint avatar digint commented on May 31, 2024
non virtual destructor

from tinyfsm.

Comments (3)

digint avatar digint commented on May 31, 2024 1

If you have already a virtual method which resources are you wasting?

At least a vtable entry, not sure what else. Building examples/api/moore_machine.cpp results in:

without virtual destructor:

# size -B -d moore_machine
   text    data     bss     dec     hex filename
   3277     768     584    4629    1215 moore_machine

with virtual destructor virtual ~MooreMachine() noexcept = default;

# size -B -d moore_machine
   text    data     bss     dec     hex filename
   3662     808     600    5070    13ce moore_machine

from tinyfsm.

digint avatar digint commented on May 31, 2024

Adding a virtual destructor would waste resources, and there is no reason to have one, as the MooreMachine class (and derived classes) is NOT intended to be deleted through a pointer to it.

Or am I missing something?

from tinyfsm.

 avatar commented on May 31, 2024

If you have already a virtual method which resources are you wasting?

from tinyfsm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.