qmp: consider deprecating LibvirtShellMonitor about go-qemu

[benlemasurier]

100% agree, my thoughts exactly.

[danderson]

My only thought is that LibvirtShellMonitor made it easy for me to get started, because it took exactly the same arguments as virsh, which I was familiar with already.

That said, that's maybe just an argument for a bit more documentation (e.g. "the libvirt unix domain socket is usually at /foo").

[benlemasurier]

I should add, my primary motivation for wanting to see the shell monitor deprecated is due to the fact that's it's also the most likely to fail. Under libvirt >= 1.3.2 and possibly earlier, we needed to patch virsh to always fflush on output.

[mdlayher]

I'd be okay with beefing up the documentation to make the RPC monitor more approachable too.

I guess there is no urgent need to yank it out, but if more issues like the one that @benlemasurier mentioned occur, I'd rather not have to tell users to patch their libvirt to use it, heh.

[danderson]

Yeah, makes sense to get rid of it.