Unexpectedly closed transaction about soriento

[dimparf]

Hi,
Current database instance is not active on current thread.
In your case, you use two instances of the database in one thread, one implitsit and one explicit.
Implicit database instance use in createOClass method (db instance defined in test package object soriento).

[stuz5000]

But won't db will used used as the implicit parameter to createOClass?

Its the 3rd save that finds the closed db -- the first two succeed, which make me think that problem is not with the createOClass call.

In fact, if I explicitly pass the same db to the createOClass, the behavior is the same (closed at the 3rd save).

    val db: ODatabaseDocumentTx = new ODatabaseDocumentTx("memory:jsondb")
    db.create()
    createOClass(classTag[Blog], db)
    createOClass(classTag[Record], db)

To be certain I'm not referencing the test DB, I moved everything into a new package separate from the test package, and I gets the same result (see below).

package net.stu

import com.emotioncity.soriento.annotations.Embedded
import com.emotioncity.soriento.{Dsl, ODb}
import com.orientechnologies.orient.core.db.document.ODatabaseDocumentTx
import org.scalatest.{BeforeAndAfter, FunSuite, Matchers}
import com.emotioncity.soriento.ODocumentReader._
import com.emotioncity.soriento.RichODatabaseDocumentImpl._
import scala.reflect.classTag

case class Record(content: String)
case class Blog(author: String, @Embedded message: Record)

class MyTest extends FunSuite with Matchers with BeforeAndAfter with ODb with Dsl {

  test("serializeTest5") {

    val db: ODatabaseDocumentTx = new ODatabaseDocumentTx("memory:jsondb")

    db.create()

    createOClass(classTag[Blog], db)
    createOClass(classTag[Record], db)

    val blog = Blog(author = "Arnold", message = Record("Agrh!"))
    db.save(blog)
    db.save(blog)

    val blogs: List[Blog] = db.queryBySql[Blog]("select from blog")
    println(blogs)
    println(blogs.size)

    val blog2 = Blog(author = "Arnold2", message = Record("Agrh2!"))
    db.save(blog2) // DB is closed here

    val blogs2: List[Blog] = db.queryBySql[Blog]("select from blog")
    println(blogs2)

    db.drop()
  }
}

[stuz5000]

Tracing the execution I found queryBySql calls ODatabaseDocumentTx].copy()

I think this is where the new instance is coming from (in RichODatabaseDocumentImpl).

    protected def blockingCall[T](payload: ODatabaseDocumentTx => T): T = {
      /*println("Blocking call")
      println(if (isPooled) "Database is pooled" else "Database is unpooled")*/
      val instance = ODatabaseRecordThreadLocal.INSTANCE.get
      //println("ThreadLocal is: " + instance.getClass.getName)
      val internalDb = if (isPooled) instance.asInstanceOf[ODatabaseDocumentTx] else instance.asInstanceOf[ODatabaseDocumentTx].copy()
      payload(internalDb)
    }

Shouldn't this be:

val internalDb = if (! isPooled) ...

[stuz5000]

This change has been merged into the dev branch. I think this fixed this (at least, it fixed my problem and broke no tests.

protected def blockingCall[T](payload: ODatabaseDocumentTx => T)
   val internalDb = if (! isPooled) ...