GithubHelp home page GithubHelp logo

Comments (3)

dinbror avatar dinbror commented on August 25, 2024

Hey @aymaysinnett

If I change it I would also need to implement something for changing the images on resize which I'm not a big fan of.
The reason why I’m looking at the device width and not the width is that I don’t want to load multiple image sources for the same image when you resize (multiple server request per image). And if you have a big screen but the start width of your browser window is something small I don’t want to upscale a low res image if you resize it up.

from blazy.

aymaysinnett avatar aymaysinnett commented on August 25, 2024

Hi, I completely understand, but at least you'll provide the option.
And yes, you will get multiple server requests per image, but only if you hit a breakpoint on upscaling.

Considering that upscaling would most likely only happen on desktop, I don't think that's a major issue compared to the disconnect between viewport and screensize for image loading.

from blazy.

mishterk avatar mishterk commented on August 25, 2024

+1 for this!

At the very least, it would be great if we could optionally enable this.

Basing the image sizes on viewport seems a lot more logical, as the viewport restricts the width of a responsive website, not the device. Swapping out the source of an image on resize isn't a drama and as @aymaysinnett mentioned, it's mostly a desktop scenario where this would happen (unless there is a change breakpoint between a mobile device's width and height, whereby orientationchange should be honoured).

I base all my work on the viewport and rely mostly on a debouncedresize event (repo) to handle this sort of transition.

If this behaviour makes it's way into this library, I'll be all over it! (because it's rad, nicely featured, and works with background images).

Cheers!

from blazy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.