ldapdomaindump silently fails about ldapdomaindump

[dirkjanm]

If the variable isn't set then there must be some exception triggered that is not caught in a try block, since otherwise the code would just continue.
I think that the treading of ntlmrelayx somehow hides it.

To troubleshoot, I suggest changing the code here with an extra try/except block:

try:
    domainDumper.domainDump()
except Exception, e:
    logging.error("Dumping domain info FAILED")
    logging.error(str(e))

This should give some more info about what is failing

[blark]

Thanks I will add that. I went into the source and added debugging it's dying at the getAllUsers() function. Adding the exception handler now to see why...

Edit: weird for some reason it's not printing out the exception. You can see the debug print statements I added in the __init__.py of ldapdomaindump between the output from ntlmrelayx...

[*] User is not a Domain Admin
[*] Dumping domain info for first time
starting domain dump
getting users
[*] Authenticating against 

[dirkjanm]

I don't know how large the domain is that you are trying to dump, but it can take a while to get all the data. Did you try running the tool standalone (not as part of ntlmrelayx) to see if it produces an error then?

[blark]

You're totally right. I was just being impatient. DOH! Thanks!

Edit: in that case, it seems that the tweak I made (moving the boolean assign to the first line) makes sense since that thread will hang until the dump is done. This way hundreds of dumps aren't started in a busy network... Do you want me to make the change and submit a pull?

[dirkjanm]

Yes good point, you could also add the exception handler from above so that in case something does go wrong, it will be shown properly.

[blark]

Done. They already accepted the pull, wow fast ;) Hey thanks again for the help and quick responses.

I have another question regarding ntlmrelayx.py what is the best way to get in touch with you?

[dirkjanm]

Easiest is to email me at dirkjan [at] sanoweb.nl
Closing this since it should be fixed now, thanks for the contribution :)