ppcomp fails to parse html file about ppwb

[asylumcs]

The error is caused by lines 146, 150 and 156 in the source file. The file has <hr></hr> instead of <hr/> and that causes the XML parser to fail. At this point I only know why it fails. I don't know yet (1) how a user could detect that situation easily, or (2) what could be changed in ppcomp to either identify it or live with it.

[windymilla]

Thanks. I hadn't spotted them.

[asylumcs]

If we don't want to consider those an error--and the HTML validator apparently says it's okay--then we should change the code to accept it. For that to happen, I believe it's as simple as putting this in the "cleanup some errors" block near line 220 of comp_pp.py:
self.parser_errlog = [x for x in parser.error_log if parser.error_log[0].type != 76]
I can start a PR for that if we want to ignore it and continue in ppcomp. Or maybe we want ppcomp to flag it and continue. Or maybe just flag it and bail out. What do we want to happen?

[windymilla]

I would be happy with flag and continue or flag and fail.

…

On Sat, 9 Jan 2021, 23:41 asylumcs, ***@***.***> wrote: If we don't want to consider those an error--and the HTML validator apparently says it's okay--then we should change the code to accept it. For that to happen, I believe it's as simple as putting this in the "cleanup some errors" block near line 220 of comp_pp.py: self.parser_errlog = [x for x in parser.error_log if parser.error_log[0].type != 76] I can start a PR for that if we want to ignore it and continue in ppcomp. Or maybe we want ppcomp to flag it and continue. Or maybe just flag it and bail out. What do we want to happen? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACEGIVKIIXPINRRYGHU2TCLSZDSR5ANCNFSM4V34HQUA> .

[rtonsing]

@cpeel @windymilla
It may pass W3C, but it does not pass Nu Html checker:
Error: Stray end tag hr.
From line 2904, column 5; to line 2904, column 9

and according to the Whatwg.org standard is not valid html.

Suggest closing.