GithubHelp home page GithubHelp logo

Comments (6)

rebeccabilbro avatar rebeccabilbro commented on May 23, 2024

Implement a base class that will follow an estimator in a pipeline (keep in mind that there could be more than one of these things stacked up along each other). This is not a transformer. It needs to extend BaseEstimator, VisualizerMixin. We also need to create a ScoringMixin. ScoringMixin has scoring function that saves the state of the scoring to the class so that we can draw it. This will have:

  • fit
  • predict
  • score
  • draw

Need to think how we'll access the model from ScoreVisualizer. Best option is to have it be instantiated with a model form - this makes sense because we would call fit down into the estimator. The trick will be that the visual pipeline needs to know not to run fit twice.

from yellowbrick.

rebeccabilbro avatar rebeccabilbro commented on May 23, 2024

@bbengfort ok, preliminary implementation here: https://github.com/DistrictDataLabs/yellowbrick/blob/develop/yellowbrick/base.py#L104

from yellowbrick.

rebeccabilbro avatar rebeccabilbro commented on May 23, 2024

ClassifierScoreVisualizers:

RegressionScoreVisualizers:

from yellowbrick.

bbengfort avatar bbengfort commented on May 23, 2024

@rebeccabilbro ok I took a look at these, and things are looking great! There are a few things that we should resolve/discuss and this issue will be done!

Also - I really like how you've separated score and draw and poof - it was the basis for everything I did in the feature visualizers!

  • decide on self.classes or self.classes_ - I guess I was thinking we'd act a bit more like Scikit-Learn; I'm open to other opinions.
  • In order to make the isestimator check happen (from the super class), we'll have to call super in __init__
  • We should elevate the model wrapping logic to ScoreVisualizer as in #62
  • What is the difference between ScoreVisualizer and ModelVisualizer?

from yellowbrick.

rebeccabilbro avatar rebeccabilbro commented on May 23, 2024

@bbengfort have addressed the first two checkboxes in commits d57102c and 76d2d1f

Will tackle the third in the next sprint.

As for the 4th, I've clarified the difference in base.py here. Essentially the main difference is that ScoreVisualizer takes a fitted model and ModelVisualizer takes a model form.

from yellowbrick.

rebeccabilbro avatar rebeccabilbro commented on May 23, 2024

Marking as complete, with the understanding that issue #62 will resolve the fig/ax hook question that came up in the design of this class.

from yellowbrick.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.