dithpri / rces Goto Github PK

Main nations are added to S3 puppet cards but remain hidden/invisible due to default NS CSS

Bugs:

• Buttons duplicate when expression is changed
• Should be disabled on card pages & show_market=decks
• asHtmlDataSetKey doesn't convert apostrophes/other invalid chars: script errors out on "nation's bids" page
  • Suggestion: treat that page's "nation's bids/asks/etc." columns as a special case
• Expression input breaks when pressing a keybind (I should've seen that coming!)
  • Suggestion: use Mousetrap instead

Features:

• Update DV/Bank on junk
• Add default_flag/game_flag boolean for use in expressions
• Add puppet value for use in expressions (body.dataset.nname)
• Use Mousetrap to not go crazy handling keybinds
• Switch to last page of deck first when using keybinds, go to previous page when processing is complete
• Close tab after finishing processing
• Highlight mismatched ask/bid (or just highlight the Match column)
• Sort when clicking on a column header

Misc:

• Extract part of the filtering function to the Row class

For I followed your notes for creating containers in Firefox but I couldn't get any of these dilema scripts to run. Further investigation seems that '@run-at document-body' isn't a valid parameter for firefox see: greasemonkey/greasemonkey#3010 and https://wiki.greasespot.net/Metadata_Block#.40run-at

So I changed them all to '@run-at document-end' and NsIssueOpener and NsIssueCompactorRand seem to be working fine. However NsDilemmaAutoClose doesn't appear to do anything and the tab never closes.

I dug around a bit since my personal version (0.2) was still working, but other people reported it no longer working and tracked it down to this fix

If there are no previousChoices, totalChoices will be empty it seems, which breaks the script with the message
TypeError: reduce of empty array with no initial value

I replaced
const totalChoices = [...Object.entries(previousChoices)].map(([, x]) => x).reduce((acc, x) => acc + x);
with
const totalChoices = Object.values(previousChoices).reduce((acc, x) => acc + x, 0);

and tested it both for issues I did not encounter before, and issues I had values for, and this fixed it.

Very cool program but I want to know how do I start the NsIssueOpener, NsIssueCompactorRand and NsDilemmaAutoClose. Is there a certain tool I need to use? Like an extension? Or an app?