Option to disable e-mail notifications about dj-stripe

[pydanny]

Hi @tomusher,

I'm thinking of having a setting that can be toggled. Then fully document the existing signals. I'm not 100% happy with that solution, so I would love to hear your input on what you think would be ideal.

Danny

[tomusher]

@pydanny Great. A toggle would be fine, but as you say, documentation would go a long way too - the main issue seems to how unpredictable things can be - some events are triggered by signals, some by webhooks, and some as side effects of calling a utility method on a model.

Ideally, I'd (personally) like to use dj-stripe purely for the structural stuff; models, utility methods and webhook/signal management, all the behavioural bits (forms, e-mail notifications, etc.) are great but would be nice if it was easier to make them optional.

[pydanny]

Now that I've been able to return to this, I've discovered that the signals we inherited from the forked project don't make it clear where the email notifications are occurring. Note: This is why I'm not a fan of the observer pattern i.e. signals...

@tomusher, were these coming from the the registration system or dj-stripe itself?

[tomusher]

Trying to think back to the problem I was having - I think it was calling 'subscribe' on a Customer, and then trying to trace where the email came from.
It seems to be sent in response to a webhook triggered by Stripe -> Invoice.handle_event -> sync_from_stripe_data -> send_receipt.
It's difficult to follow but also pretty difficult to intercept to change the behaviour.

[buddylindsey]

I have had to track down this path a few times for various reasons. Here it is again to give better path for it:

Enters the webook call for "Invoice.payment_succeeded" and builds the vent then calls the process method:
https://github.com/pydanny/dj-stripe/blob/master/djstripe/views.py#L110

In the process method it makes sure it is an Invoice namespaced webhook and calls the handle_event method
https://github.com/pydanny/dj-stripe/blob/master/djstripe/models.py#L183

The start of the handle_event method is here and it goes through to the sync_from_strype_data
https://github.com/pydanny/dj-stripe/blob/master/djstripe/models.py#L766

After going all the way through the sync function it gets the charge object if there is one
https://github.com/pydanny/dj-stripe/blob/master/djstripe/models.py#L757

Then finally sends the receipt
https://github.com/pydanny/dj-stripe/blob/master/djstripe/models.py#L762

I have traced this a few times because of the inconsistency of sending emails at times.

[buddylindsey]

Forgot to add the only other place I could find a call to send_receipt as here:
https://github.com/pydanny/dj-stripe/blob/master/djstripe/models.py#L579

[pydanny]

This is fixed in #80.