"Cancel my subscription" does not cancel my subscription about dj-stripe

[dollydagr]

I just understood the "at_period_end" logic. So "at_period_end" should indeed remain True (unless we want a different website usage model). However, the feedback message "Your subscription is active" is misleading. The template _subscription_status should instead return "Your subscription has been canceled. However you could use this website for another {until_end_period}".

The problem is that the template cannot not distinguish active subscriptions from those that have been canceled with "at_period_end=True". Therefore, for both it displays "Your subscription is active".

The way to go around this would be to rely on "CurrentSubscription.canceled_at": if "CurrentSubscription.cancel_at" exists, it means that the a subscription has been canceled and is only active until its "end_period", otherwise it's just (regularly) active. There is another "but", as the "cancel_at" attribute is set nowhere (and can currently not be relied on), whereas it should be set to a DateTime value (e.g. timezone.now()) in "Customer.cancel_subscription()".

If this is done, then the two cases (subscription truly active vs. has been canceled but is active until end_period) can be distinguished in the _subscription_status template.

[pydanny]

Hi @dollydagr - Do you have a pull request for this available or should I do the fix?

[dollydagr]

Hi @pydanny - Yes, I just posted it!

[pydanny]

Sorry I did not see that you and Yasmine Charif had a pull request in the queue.