license, docs and tests missing from pypi sdist about django-classy-tags

[maddrum]

Waiting for that release to migrate to django3.

[FinalAngel]

we have just released classy tags 1.0.0 with Django 3 compatibility :)

[dvzrv]

@FinalAngel Thanks for the release!
However, the sdist still doesn't contain the tests, so this ticket is still valid. If you want I can do a pull request for MANIFEST.in to fix this.

[FinalAngel]

@dvzrv sorry I overread this. The tests are currently not part of the package by intention (design decision by our team). It could be as easy as to remove: https://github.com/divio/django-classy-tags/blob/master/setup.py#L50

Though considering that we practice this on all our packages I'm hesitant on changing it only for this package...

[dvzrv]

@FinalAngel maybe there's a misunderstanding about the tests directory and which tarball I'm referring to.

To my understanding MANIFEST.in is used to (more specifically) define what goes into a source tarball (when using python setup.py sdist).
The setup() function on the other hand defines what will be installed to a target system, when packages have been built (python setup.py build) from a source tarball (with find_packages(), include_package_data or package_data giving more finely grained access over what is included/excluded) and then installed (python setup.py install).

While it is absolutely reasonable to exclude the tests from e.g. a wheel distributable (python setup.py bdist_wheel), which happens automatically because of your above stated line in setup(), it is not good to distribute the sdist without tests (because noone can test the sources after building from them when using the tarball from pypi.org).