File/Image Widget: File selection does not work in new inlines about django-filer

I was able to fix this by overriding _media on my inline class and provide a new inlines.min.js file.

The key was to add img and span to the selector used in that class to reset ids and adding or removing inlines. It was input,select,textarea,label,a and I changed it to input,select,textarea,label,a,img,span

[stefanfoulis]

thanks for the pointer. I guess we could provide a InlineAdmin subclass that does that. But it would be unintuitive to developers if they have to use a special subclass just so the FileField works. I'll have a look at the markup. Maybe we can change the widget markup in a way that it works with the standard inlines.min.js

what's strange to me is that it worked in django 1.2.4 but not 1.2.5. I was trying to figure out what changed, but no luck yet. looks like inlines.min.js is the same between the two versions.

I would agree that changing the mark-up would probably be the best route. Providing an InlineAdmin sublcass and the new inlines.min.js file would definitely be unintuitive.

[stefanfoulis]

Actually the widget markup changed a bit recently. We added a link to the full size image and moved from generating the markup in python code to using a template.
It's pretty surprising the whole thing works with that change of yours... after all there is a bunch of javascript in there. How could that ever be cloned correctly?

https://github.com/stefanfoulis/django-filer/blob/develop/filer/templates/admin/filer/widgets/admin_file.html

oh, i was saying that inlines.min.js is the same. only difference I can tell from the widget markup is that in django 1.2.4 the label tag still has 'prefix' in it's for attribute. where in 1.2.5 it has the new index of the inline. not sure if that is making a difference. doesn't look like you control that label though, django does. yeah, my fix is a complete hack. inlines.min.js just provides functions to resync up ids when you add or delete inlines so I changed the selectors to include img and span.

[stefanfoulis]

I can't re-produce the error in django-1.3 and have not tested it yet in django-1.2.x.
This seems to be an issue exclusively in django-1.2.5.

[stefanfoulis]

I checked this again with the current versions (django-filer develop, django 1.4) and could not reproduce it. Since this seems to be a django-1.2.x issue and we're dropping official 1.2.x support, I'm closing this issue.