Comments (5)
3fb2c1a should've fixed this problem
any chance you are using it on Divio Cloud? if that's the case and the addon was upgraded - please make sure that the static files and template are removed from the project.
i will try to reproduce in the meantime
from djangocms-icon.
I'm using version 1.0.0. Let me know if you cannot reproduce the issue.
I'll have a look at removing the templates and statics. It is indeed a customized docker image we're using.
Edit: I deleted the statics and templates - this did not change the behavior. Selecting an icon from the 2nd iconset leaves the user with a preselection of the first icon of the first iconset when opening the admin/plugin again...
Edit2: @vxsx I noticed this behavior only with 2 SVG sprites so the first step of the reproduction is wrong.
The setting should look like this:
DJANGOCMS_ICON_SETS = [
(ICONSET, 'icon', 'SVG icons'),
(ICONSET2, 'icon2', 'SVG icons 2'),
]
from djangocms-icon.
I can reproduce the problem with 2 svg iconsets, thanks, looking into this
from djangocms-icon.
It looks like the field renderer tries to infer the iconset out of the icon name:
Meaning that if value is icon-something
it would think that the prefix is icon
. So it would select the iconset based on that. And in case the iconset prefix doesn't match the one in settings it would always pick the first one no matter what. This is likely what leads to the bug you're experiencing
from djangocms-icon.
I can confirm this. Changing the prefix in my second symbol-def SVG file make the whole thing work.
from djangocms-icon.
Related Issues (11)
- Support for Font Awesome 5 Pro HOT 25
- Version 1.3.0 breaks compatibility with djangocms-bootstrap4
- Can not find icons HOT 1
- Icon is not displayed in django_bootstrap4_link HOT 1
- a sample of the assets.html HOT 1
- Fix a mistake in the documentation
- fontawesome support for version 6 planned? HOT 2
- Django 4.2/DjangoCMS 3.11 support HOT 1
- Add steps for installing Font Awesome
- Update (or document) for use with current Font Aweseome 5.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from djangocms-icon.