Customizing LineAttributeSerializer about django-oscar-api

[kooba]

Looks like it was pretty straightforward after all. Leaving this for future reference.

All I had to do was to:

add code property to oscar's AbstractLineAttribute:

class AbstractLineAttribute(models.Model):
    (...)
    @property
    def code(self):
        return self.option.code

and code serializers.CharField to oscarapi's LineAttributeSerializer

class LineAttributeSerializer(OscarHyperlinkedModelSerializer):
    code = serializers.CharField(max_length=128)

and then adding code to fields in BasketLineSerializer

class BasketLineSerializer(OscarHyperlinkedModelSerializer):
    (...)
    attributes = LineAttributeSerializer(
        many=True, fields=('url', 'option', 'value', 'code'),
        required=False, read_only=True)
   (...)

[maerteijn]

Hi @kooba

You're solution is indeed ok and it is documented like this in the djangorestframework documentation.

However, to solve this properly you need to fork the basket app from oscar just to override the LineAttribute model (https://django-oscar.readthedocs.io/en/releases-1.5/topics/fork_app.html), and you needed to override oscarapi's serializers.

You could solve it as well by just overriding oscarapi's serializers (see https://django-oscar-api.readthedocs.io/en/latest/usage/customizing_oscarapi.html), and do something like this:

from oscarapi.serializers import LineAttributeSerializer, BasketLineSerializer


class MyLineAttributeSerializer(LineAttributeSerializer):
    code = serializers.SerializerMethodField()

    def get_code(self, obj):
        return obj.option.code


class MyBasketLineSerializer(BasketLineSerializer):
    attributes = LineAttributeSerializer(
        many=True, fields=('url', 'option', 'value', 'code')
        required=False, read_only=True)

Good luck!

[kooba]

Thank you!

Yes of course, all the changes were applied on the fork as described in oscar api customization docs.