Error in tests about django-oscar-api

[maerteijn]

@gogobook Thanks for the clarification.
Note that you are reporting this against a development version of Oscar, not the official supported versions as stated in the docs

Now that's been said: It's actually not an issue of oscarapi. However, I created a pull request for Oscar to fix this: django-oscar/django-oscar#2682

I will close this issue when it's merged.

[maerteijn]

As you can see on travis , the tests do pass. Can you explain a bit more please. "testoffer.py and testbasket.py is an error." is a bit vague.

[gogobook]

When I try to develop oscarapi with oscar(338cb7c), I get "NoneType" error by follow message

File ".../oscarapi/views/basket.py", line 78, in validate
    allowed, message = basket.is_quantity_allowed(quantity)
File ".../oscar/apps/basket/abstract_models.py", line155, in is_quantity_allowed
    max_allowed, basket_threshold = self.max_allowed_quantity()
TypeError: 'NoneType' object is not iterable

This is some source code of oscar(338cb7c) in basket/abstract_models.py:

    def max_allowed_quantity(self):
        """
        Returns maximum product quantity, that can be added to the basket
        with the respect to basket quantity threshold.
        """
        basket_threshold = settings.OSCAR_MAX_BASKET_QUANTITY_THRESHOLD
        if basket_threshold:
            total_basket_quantity = self.num_items
            max_allowed = basket_threshold - total_basket_quantity
            return max_allowed, basket_threshold

    def is_quantity_allowed(self, qty):
        """
        Test whether the passed quantity of items can be added to the basket
        """
        # We enforce a max threshold to prevent a DOS attack via the offers
        # system.
        max_allowed, basket_threshold = self.max_allowed_quantity()
        if max_allowed is not None and qty > max_allowed:
            return False, _(
                "Due to technical limitations we are not able "
                "to ship more than %(threshold)d items in one order.") \
                % {'threshold': basket_threshold}
        return True, None

if setup "settings.OSCAR_MAX_BASKET_QUANTITY_THRESHOLD = None" will get TypeError: 'NoneType' object is not iterable.