GithubHelp home page GithubHelp logo

Comments (13)

djett41 avatar djett41 commented on August 23, 2024

Thanks @booris !! Are you seeing a lag on the actual device or emulator? The iOS emulator often has a lag because of the lag with the keyboard, but I haven't really seen a lag on device? Any way you could post a video on it? I just want to see where and when it lags so I can look into making it better.

Thanks!!

from ionic-filter-bar.

pateltejasmca avatar pateltejasmca commented on August 23, 2024

I am also facing the same issue in my moto g1.

from ionic-filter-bar.

pateltejasmca avatar pateltejasmca commented on August 23, 2024

@djett41 Thanks for your work. Its very helpful for me

from ionic-filter-bar.

cagica avatar cagica commented on August 23, 2024

Sorry, I'm on vacation when I come back, I will try to show you the lag. @pateltejasmca you can put a timeout of 280 milliseconds around the input call on the code. And it will be fine. Try it.

from ionic-filter-bar.

cagica avatar cagica commented on August 23, 2024

Focus call. In the function show keyboard, you can put a timeout around the focus & & focus()

from ionic-filter-bar.

djett41 avatar djett41 commented on August 23, 2024

thanks guys! I started a new job and have been swamed but ill take a look. Only thing about calling timeout on the input is that the keyboard wont come up at the same time as the filter bar.. which is not what we want on ios. Is this the case for android? Or does your solution bring the keyboard up at the same time as the filter bar animates in @booris ? I'll play with it sometime this week

from ionic-filter-bar.

cagica avatar cagica commented on August 23, 2024

In the best case we want the keyboard opening at the same time as the filter bar, that is true. But in some smartphones (weaker ones) the animation of the filter bar entering has lag because the keyboard is opening at the same time, and it's worst than opening the keyboard a little bit latter. Instead of changing your directive you can simple add an atribute that allow users to choose if the keyboard open's when bar is animating or after the bar is entered.

from ionic-filter-bar.

cagica avatar cagica commented on August 23, 2024

I made two videos, one you can see the lag, and the other it has the timeout. The diference in opening the keyboard is small. http://we.tl/S4iCL7oWG9

from ionic-filter-bar.

djett41 avatar djett41 commented on August 23, 2024

@booris you might want to try overriding the animation delay in the scss/css file as well.

from ionic-filter-bar.

RameshJhajharia avatar RameshJhajharia commented on August 23, 2024

@djett41 Thanks for the amazing work.
@booris I am also facing same issue. Did you find any solution for this?

from ionic-filter-bar.

cagica avatar cagica commented on August 23, 2024

@RameshJhajharia You can see my pull request and see what I did

from ionic-filter-bar.

ekaram avatar ekaram commented on August 23, 2024

+1

from ionic-filter-bar.

armenbadalyan avatar armenbadalyan commented on August 23, 2024

I'm experiencing this as well on my Sony Xperia Z2 running Android 5.1. What's interesting the SportScoop app which is presumably using the same directive doesn't have any lag during animation on the same device.
@pcagica I've tried using your fix for this and although it does improve the animation when the input gains focus, there's still a lag when I cancel the filter bar and the keyboard slides away.

I've attempted to fix this issue in my fork. See this commit.

The solution is based on transitionend event to detect when the animation finishes.

from ionic-filter-bar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.