When paging backwards, page.paging.items() seems to misalign bookmarks and values about sqlakeyset

[mattalbr]

Confirmed on my end that our unit tests pass now! I'll let you know if we hit any more snags, but it seems as long as we avoid #54 everything is working smoothly. Thanks for the fast responses and the handy library!

[acarapetis]

Thanks for the report! I didn't look too closely at the tests for the new .items() method, turns out we're testing for incorrect behaviour! I've got a fix in the pipeline now, will hopefully have a new release out soon.

[acarapetis]

New release should hit PyPI within an hour, please let us know if you have any further issues :)

[mattalbr]

Thanks for the super prompt fix!

[mattalbr]

Sorry to reopen, now I believe there's an off-by-one error with the keyset relative to the value when paging backwards with entries before the end of the current page.

e.g

["a", "b", "c", "d", "e"]
last 3 before "e" gets you:
{cursor: "a"
value: "b"}
{cursor: "b"
value: "c"}
{cursor: "c"
value: "d"}

Is it possible that we fetch an extra bookmark in order to check page before/after and when you just reversed markers in that PR, it's messing up the sentinel value?

[acarapetis]

@mattalbr Oh dear!

Is it possible that we fetch an extra bookmark in order to check page before/after and when you just reversed markers in that PR, it's messing up the sentinel value?

Yup, dead on - tests only covered the case where there was no excess, i.e. the page went all the way to the end of the resultset. Fix incoming.