Comments (5)
@wilzbach As a Servo developer, I can say it's not that noisy, and quite useful. Also it can offer people some bragging points sometimes, each of these referenced pull requests were bitrot all at once with one of mine when it landed. :)
from dlang-bot.
@wilzbach As a Servo developer, I can say it's not that noisy, and quite useful.
I think if we start this by just labelling unmergable PRs, this would already be an excellent step. Whether we then send the comment (or personal emails) or not, is than "merely" philosophical (or political).
In case you are interested, I submitted a PR of the first iteration of such a feature here (#52), so maybe we can seen the bot reporting this in the near future ;-)
from dlang-bot.
I submitted a PR of the first iteration of such a feature here (#52), so maybe we can seen the bot reporting this in the near future ;-)
This is deployed and we now (experimentally) label PRs as "needs rebase" once a day.
See e.g. https://github.com/dlang/phobos/pulls?q=is%3Aopen+is%3Apr+label%3A%22needs+rebase%22
Sending out notifications would be a rather trivial step on top of that, but I am still afraid that it's too spammy. Maybe we can add a simple mechanism for a user to opt-out?
from dlang-bot.
We have a needs rebase label nowadays.
from dlang-bot.
Regarding mail @wilzbach, it seems we'd need a user preference for E-Mail heavy workflows.
Personally I've almost abandoned E-Mail, so I can not really decide what's useful or not, when your work is centered around it. It's just that we also have to consider the visual cluttering in the important comments.
A custom Webextension to make dlang-bot comments less present would work for me, but hardly helps other people. Already have a userContent.css for github to make the news list opaque.
@-moz-document url('https://github.com/') {
div.news { opacity: 0.1 !important; }
}
from dlang-bot.
Related Issues (20)
- clear shutdown of CI servers before deleting them
- Smart WIP handling HOT 3
- Bot does not recognize the switch from a draft PR to a full PR
- Bugzilla description partially discarded HOT 2
- Testsuite doesn't run on Alpine Linux / Musl HOT 1
- Don't merge PRs where non-required status are failing HOT 3
- Continuous TLS error on Scaleway API HOT 6
- Deployed Heroku instance should have debug infos HOT 1
- Bot ignore Azure pipelines failures HOT 2
- Bot cannot post on issues with Vibe.d v0.8.6 HOT 1
- The bot wrongly closes bugzilla issues from events generated by dlang-community projects HOT 1
- Query state of GitHub issues HOT 2
- Detect weblinks as reference to bugtracker issue HOT 6
- Update last commit message when merging with links to the PR and its title HOT 1
- Heroku stack is deprecated HOT 1
- dlang-bot for dub didn't tag the latest release HOT 1
- Bot didn't catch second bugfix HOT 2
- Tweaking bot with draft might be possible HOT 1
- Spurious escape in bug description HOT 1
- BUG: The dlang-bot doesn't Resolve Issues whose PRs Target the table branch HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dlang-bot.