Comments (3)
I found the cause for this issue. It's not actually an issue in itself.
This happens, when the .env.production
does not define REACT_APP_SETTINGS_FILE
.
After defining the variable, the production release works.
Do you think we should default this variable to production
?
Edit: Or inform the user somehow about the missing config option?
from lisa.
Weird, I thought that production
is the default value defined in .env.production
. You can try to use get to define default value: get(process.env, 'REACT_APP_SETTINGS_FILE', 'production')
.
from lisa.
It is. As I found out we overwrite this file prior to building the production bundle because we define our GraphQL API target there. Doing so, the previously defined variable REACT_APP_SETTINGS_FILE
got removed resulting in this behaviour.
Using your proposed code works as well. I will go ahead and open a PR for it
from lisa.
Related Issues (20)
- VM gets created with wrong interface type HOT 1
- Build of LISA with plugins breaks with "Cannot find module: '@apollo/react-hooks'" HOT 2
- Move the puppet stuff to the Lisa plugin
- Enable LISA to ask for additional fields / make fields customizable
- Creating two hosts with low-privileged User causes second system to fail
- Hostname validation doesn't work for non-admin user
- Migrate to Vite
- Plugins API: change the order of the extensions
- `computeResourceId` does not get set correctly in the final host creation call
- puppetclass_ids are removed when selecting a different puppet-environment HOT 1
- Search is currently broken and shows "[object Object]"
- Hosts pagination
- Allow to set the firmware_type for the OS
- Implement oauth/oidc auth in LISA
- Default puppetclass_ids do not work HOT 1
- Creation of VM fails due to "undefined method `resourcePool'"
- Add screenshots to README
- Update Patternfly to v4
- Hostname does not contain appTier and domainName
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lisa.