GithubHelp home page GithubHelp logo

Comments (5)

dmitry-ivanov avatar dmitry-ivanov commented on May 17, 2024 1

Hi!

I've fixed the first part, 5.7.5 released.

According to the Illuminate\Foundation\Exceptions\Handler... I'm not sure what solution can be used for the Lumen. Package can't rely on the app\Exceptions\Handler.php, because it's a project specifics, and the App namespace is just the default, which is customized by many applications.

Probably it was a mistake to rely on the Illuminate\Foundation classes, maybe I should use the contracts. I will take a look on that issue later.

Thanks!

from laravel-console-logger.

mstaack avatar mstaack commented on May 17, 2024

would love to see some improvements for lumen

from laravel-console-logger.

mstaack avatar mstaack commented on May 17, 2024

actually looking at the new log channel / stack implementation in lumen/laravel...pretty close

from laravel-console-logger.

alekstr avatar alekstr commented on May 17, 2024

Hey, is it possible to merge the normilize part fix to 5.2 branch? =) Thanks!

from laravel-console-logger.

dmitry-ivanov avatar dmitry-ivanov commented on May 17, 2024

I think it's possible to use the decorator pattern for the ExceptionHandler, for example, like here.

In that case, the ExceptionHandler class might just implement the Illuminate\Contracts\Debug\ExceptionHandler contract, without extending the Illuminate\Foundation\Exceptions\Handler class.

Anyway, I prefer not to bother with Lumen for now because I don't use it at all.

from laravel-console-logger.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.