GithubHelp home page GithubHelp logo

Comments (3)

gc00 avatar gc00 commented on September 26, 2024

Good point! I assume we keep -h and -p. Should we have three synonymous flags and two environment variables temporarily for backward compatibitity?
-h --host --coord-host
DMTCP_HOST DMTCP_COORD_HOST
and the same for ports?
I'll volunteer to create the pull request. Is that the right spec? (In a future release, we can remove DMTCP_HOST and DMTCP_PORT, but we'll keep it for DMTCP 2.4.0.)

from dmtcp.

gc00 avatar gc00 commented on September 26, 2024

For testing, we'll need to test for dmtcp_launch --no-coordinator, as well as dmtcp_launch -p0, and the combination of the two. Similarly, need to test for dmtcp_restart -p0, and we need to test dmtcp_coordinator and dmtcp_command. Note also that what DMTCP does with DMTCP_HOST/PORT environment variables currently is rather haphazard. Also, after dmtcp_restart --port XX, when we call mtcp_restart, we revert back to the previous environment variables or information in the SharedData area.
We also need to test for dmtcp_launch -p0 --port-file MYFILE (and without -p0).

from dmtcp.

gc00 avatar gc00 commented on September 26, 2024

This issue has now been fixed by pull request #92.

However, notice that issue #93 has now been opened, due to a related issue that affects dmtcp_restart saving the old pre-ckpt DMTCP_COORD_PORT in its memory, and then using the old value to re-connect to the coordinator in cases where the socket temporarily breaks. This doesn't work if there is a new coordinator on a different port after restart.

from dmtcp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.