Need add support for LIBSPDM_ENABLE_VENDOR_DEFINED_MESSAGES about spdm-emu

[jyao1]

@uvinrg, would you please submit a patch to enable spdm-emu?

[uvinrg]

Hi @jyao1 I would like to update spdm-emu so it works as expected with the new patch. Can you provide me with a quick guide how to run the IDE_KM test, so I can verify afterwards the patch worked? Thank you.

[jyao1]

Sure, thank you!
Just run both spdm-emu, please. Originally, emu will send IDE_KM and get response. Now emu cannot because there is no code to register the new callback when LIBSPDM_ENABLE_VENDOR_DEFINED_MESSAGES is enabled.

[jyao1]

@Wenxing-hou , please investigate why CI did not catch this issue

[Wenxing-hou]

@Wenxing-hou , please investigate why CI did not catch this issue

Hi all. I have investigated the SPDM-emu. The current spdm-emu doesn't call the libspdm_try_vendor_send_request_receive_response and libspdm_get_vendor_defined_response.

The reason is:
When I added the dead loop in the submodule libspdm, such as:

libspdm_return_t libspdm_try_vendor_send_request_receive_response(
    libspdm_context_t *spdm_context,
    ...
    void *resp_data)
{
....
while(1);

libspdm_return_t libspdm_get_vendor_defined_response(libspdm_context_t *spdm_context,
                                                     size_t request_size,
                                                     const void *request,
                                                     size_t *response_size,
                                                     void *response)
{
...
while(1);

The spdm-emu run successfully without stop.

[jyao1]

The current spdm-emu doesn't call the libspdm_try_vendor_send_request_receive_response and libspdm_get_vendor_defined_response.

@Wenxing-hou , why it does not call?

The reason is:
When I added the dead loop in the submodule libspdm, such as:

This is NOT the reason. This is just the consequence of "not call".

[uvinrg]

@jyao1 Running spdm_responder_emu and spdm_requester_emu without parameters works, though at some point responder return ERRRO 0xFE after a few messages.
I have created pull request DMTF/libspdm#2533 to fix Libspdm vendor commands backwards-compatibility with existing code. It should fix the problem.