Not using `present_params` about filterer

[olliebennett]

Your issue seems to be two parts;

Filtering for empty string

I think (regardless of the implementation), a user may assume that leaving a blank field (empty string) would not filter on that field at all; i.e. if you leave "age" blank, you would not filter by "age" at all.

I use the keyword BLANK to indicate an explicit search for "" on a given field. My filter config therefore looks like this;

  def param_age(age_query)
    return @results.where(age: nil) if age_query == 'BLANK'

    @results.where(age: age_query)
  end

Filtering with two fields at once

This can be achieved by deferring the logic to only one of the methods, although it's a little ugly.

  def param_age(age_filter)
    return @results.none if params[:rank].blank?

    @results.where(age: age_filter, rank: params[:rank])
  end

  def param_rank(_)
    # ignored here as rank cannot be filtered in isolation; see param_age.
  end

Hope that helps with your use-case, at least?

[ramontayag]

Cool. I forgot about this! I'm no longer working on the project that needed this, and I'm not sure what I did. Cheers, and happy new year!

And yes, it does sound like what you put will solve it!