consistent addressing about classicswarm

[vieux]

I agree there are things to fix in swarm,
I'm afraid, as you said, it's too late to fix $DOCKER_HOST in docker.

I'll update the documentation when it's possible.
Regarding The swarm join command uses --addr for specifying the IP & PORT
and The swarm manage command uses --host for specifying the IP & PORT

It's not the same flag on purpose (I'm not saying it's the right flag name) for manage we are using the same flag as Docker because your are actually starting some sort of Docker Daemon. For join we publish the addr we want to advertise.

I think the 1st thing we need to fix is the protocol issue.

Here is what I would like to do:

• The discovery service will always receive and return addr with protocol.
• Only 3 protocol are valid
  • http
  • https
  • tcp (will be replaced by http or https whether or not you have a tls.Config)
• If you pass an addr without protocol, tcp will be prepended

This will be related to: The swarm list and docker info commands output the format http://1.2.3.4:2375 because it depends of what you send.

Thanks for reporting those issues, do you have any suggestion to improve ?

[vieux]

see #208

[vieux]

see #237

[vieux]

I believe we solved most of the issues ?

We can't change -H as we use it to match docker's flags

[phemmer]

Well in it's current state, it's now broken for me:

# cat .swarm_discovery 
172.17.0.28:2375
172.17.0.29:2375
172.17.0.30:2375

# docker info
Containers: 0
Nodes: 0

And the swarm daemon logs are spitting out:

2015-01-19 20:20:10 swarm: time="2015-01-19T20:20:10-05:00" level=error msg="Get 172.17.0.28:2375/v1.15/info: unsupported protocol scheme \"\". Are you trying to connect to a TLS-enabled daemon without TLS?" 
2015-01-19 20:20:10 swarm: time="2015-01-19T20:20:10-05:00" level=error msg="Get 172.17.0.29:2375/v1.15/info: unsupported protocol scheme \"\". Are you trying to connect to a TLS-enabled daemon without TLS?" 
2015-01-19 20:20:10 swarm: time="2015-01-19T20:20:10-05:00" level=error msg="Get 172.17.0.30:2375/v1.15/info: unsupported protocol scheme \"\". Are you trying to connect to a TLS-enabled daemon without TLS?" 

According to the docs, that should work.

[vieux]

@phemmer you need to update dockerclient (go get -u)
Can you do this and try again ?

[phemmer]

ahha, sorry about that :-)

Then yes, I think all is well enough. Though in response to #237, docker -H 1.2.3.4:2375 works fine for me. No tcp:// prefix needed.

[technolo-g]

Everything seems to be working for me as well.

[aluzzardi]

Can we close this down?