V1.6.0 throws errors in Symfony context about collections

[Ocramius]

Handled and tested: preparing release.

[Ocramius]

As noted in #177 (comment), scavenging vendor/ for annotations is not a good idea. This is an issue to be reported in APIPlatform.

[stof]

Well, multiple Symfony component needs to be able to read metadata (potentially using annotations) from arbitrary classes (Validator and Serializer are the one coming to my mind right now).
And at least for these 2 components, it is very common to use them on object graphs involving Doctrine collections (as a common use case is to use them on your entities).
Most of the time, you won't need any metadata there, as you want to treat the collection with the standard handling of Traversable. But this does not mean that Symfony forbids defining a custom behavior, and so it still tries to find the metadata.

The fix for that would be to ignore the Psalm-specific tags in doctrine/annotations by default, as is done already for phpdoc tags.

[Ocramius]

Yeah, currently patching doctrine/annotations, since - is not a valid class identifier anyway

[Ocramius]

Please note: you'll need doctrine/collections 1.6.1 along with doctrine/annotations 1.6.1.

[stof]

hmm, regarding @template itself, ignoring it might cause issues with the \Sensio\Bundle\FrameworkExtraBundle\Configuration\Template annotation though, in case the ignore list is case sensitive

[Ocramius]

Can you check if #186 fixes this, or if we still need to ignore these annotations?

[stof]

this won't fix it, as doctrine/annotations will still complain. But it will make it simpler to ignore it by default.

[Ocramius]

Interesting that it parses @psalm - easier to skip indeed though :)

[stof]

@Ocramius doctrine/annotation will parse everything starting with @, unless explicitly configured to be ignored. That's how it works, so that it can report mistakes where you forgot to import the annotation.

[stof]

hmm, automatically excluding anything containing a - indeed solves it pretty nicely.

[trompette]

Time to revive https://wiki.php.net/rfc/annotations or https://wiki.php.net/rfc/annotations_v2 ! 😉

[Ocramius]

@trompette this has nothing to do with the current problem.

[Ocramius]

Meanwhile, re-opening here, while working on the issue 👍

[Ocramius]

I've provided doctrine/annotations#257 - give it a shot please :)

[jverdeyen]

Still has this error for me when using dev-master using it in a Symfony 4.2 app.

[Semantical Error] The annotation "@psalm" in class Doctrine\Common\Collections\AbstractLazyCollection was never imported. Did you maybe forget to add a "use" statement for this annotation?

[greg0ire]

Using dev-master, will not help, this is not merged yet. @Ocramius, https://twitter.com/greg0ire/status/1089973726429499392?s=20

[greg0ire]

@jverdeyen it is merged now, but in the 1.6 branch.