Allow queries to be "explained" in WebProfilerBundle about doctrinebundle

[stof]

I really like the idea. This will require some refactoring of the data collector (and of course the displaying in the webprofiler).

I will work on it this weekend.

[Tobion]

Related to symfony/symfony#2930

[stof]

@Tobion It is a totally different thing. When explaining the query, I will never replace the parameters by hand. I will simply let PDO bind them when running the EXPLAIN query.

[Tobion]

I see, so you also want to provide a UI for the EXPLAIN result.

[stof]

This cannot be implemented currently.
The DBAL logger is called before conversion from the PHP values to the database values. Because of this, the profiler has to sanitize the queries because the parameters may not be serializable. So we cannot execute the query again with EXPLAIN.as we are not able to bind the parameters again.

Btw, the feature request linked by @Tobion cannot be implemented either for the same reason

[Tobion]

I think it should be changed in that the DBAL logger only logs the database values. The PHP values are not usefull in this case.

[stof]

@beberlei what do you think about it ?

[guilhermeblanco]

@stof I'm ok with this change, specially because this currently means Logger is unusable to log, so against its concept.

Even though, this change may be considered as a BC break, it sounds like a bug to me (because what is logged is not actually the query executed neither the parameters are the correct ones)

[stof]

@guilhermeblanco anyway, to be able to use such change in the DBAL logger for Symfony 2.1, we need to have this change in Doctrine 2.2. Is it too late already ?

[guilhermeblanco]

@stof it will depends of how @beberlei is going to consider this
. I'd consider as a bug, so fixing it would be valid. If he also considers on this perspective, it will be in 2.2

[beberlei]

@stof I am +1, but i cant yet see how it works in the code. Happily awaiting a PR. Will merge this into 2.2

[stof]

Implemented by #12