GithubHelp home page GithubHelp logo

Comments (5)

henrikbjorn avatar henrikbjorn commented on June 25, 2024

Still waiting on that blog post :) Until another best pratice is determained this is still the best solution imo.

from doctrinebundle.

lsmith77 avatar lsmith77 commented on June 25, 2024

i would be happy if we can improve the current situation. in order to handle clashes better, we might also want to support black listing and now just white listing when the user has to manually decide which Bundles use what manager. but we also need to ensure things stay easy to config even for Bundles that provide models for different managers that the user wants to use in the same app

from doctrinebundle.

dbu avatar dbu commented on June 25, 2024

note that we since then have a compiler pass helper for bundles that want to support multiple doctrine variants. auto-detection maybe is just too much. http://symfony.com/doc/current/cookbook/doctrine/mapping_model_classes.html

FOSUserBundle does it like this to be compatible with older versions of DoctrineBundle
https://github.com/FriendsOfSymfony/FOSUserBundle/blob/master/DependencyInjection/Compiler/RegisterMappingsPass.php

from doctrinebundle.

stof avatar stof commented on June 25, 2024

making auto_mapping pointing to the bundle itself can be an issue because it would mean that Doctrine will need to run annotations on the whole bundle when you ask for entity classes.
and if you have a bundle supporting both the MongoDB ODM and the ORM, and they are both enabled in the project, you will still want to map the bundle for only one of them generally (the one configured to be used by the bundle). The autodetection would cause some issues in such case.

The second part is indeed covered by the new compiler passes

from doctrinebundle.

ostrolucky avatar ostrolucky commented on June 25, 2024

As far as I see logic of this is in symfony doctrine bridge, so if this is important, this issue should be raised there. And as far as we see, this didn't gaing much traction and issue itself is confusing - title talks about different things than description and description proposes two different things. If comments address right thing, we agree with @stof and @dbu opinion that making automapping scan whole bundle dir by default might be too much. Feel free to reopen issue with more concrete proposal.

from doctrinebundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.