Comments (15)
Another better example is in \Doctrine\MongoDB\Query\Builder
the return types for functions like field(..), equals(..), where(..) is @return Query
instead of @return Builder
.
from mongodb-odm.
Would you be willing to submit a PR to fix these?
from mongodb-odm.
I'm sorry, but what does PR stand for?
from mongodb-odm.
Pull request.
No apology necessary :)
from mongodb-odm.
ha, stupid me. Should be an obvious term on git. I'm still on the SVN bandwagon, so figuring out the git mechanisms will take me a while. I'm going to try my hands around a little. But does there happen to be an easier for me to contribute towards this issue? Since I'm going to be using ODM heavily this month, I can fix any broken PHPDoc blocks.
from mongodb-odm.
Sounds like an excellent opportunity to learn some basic Git, actually. Fork the repository in GitHub, clone your fork to your computer, make the changes, commit the changes, push the changes, submit a PR.
from mongodb-odm.
Sounds good. Should I submit a PR frequently or only once I've covered a substantial amount of PHPDoc fixes?
from mongodb-odm.
One PR with everything would be awesome.
from mongodb-odm.
Ok, I'll try my best :)
p.s: closed that issue by mistake.
from mongodb-odm.
Tell me if a fix like this would be acceptable? epicwhale/mongodb@eec4105#lib/Doctrine/MongoDB/Query/Builder.php (that belongs from the mongodb library, but just use it as an example)
I just want to make sure I'm doing the right thing and the final push will actually be accepted into the master branch.
from mongodb-odm.
I've been fixing more of it. Could you tell me if there are any objections to my PHPDoc improvements?
epicwhale@570c1da#lib/Doctrine/ODM/MongoDB/Query/Builder.php
from mongodb-odm.
Your work looks good to me.
from mongodb-odm.
Great. I'll do the same for the mongodb library as well and update you when I'm done. It's going to take a while. Any major changes to the API planned in the coming weeks? I don't want to be witnessing conflicts when I pull.
from mongodb-odm.
The most important bits are already covered (since these will be used by end-developers). Here's the pull request: #128
from mongodb-odm.
if you want to make more changes please send a PR.
from mongodb-odm.
Related Issues (20)
- require-checker failing because of /lib/Doctrine/ODM/MongoDB/Aggregation/Stage/GraphLookup/Match.php HOT 5
- Add option to exclude collection from creating via doctrine:mongodb:schema:create command HOT 1
- ReferenceMany "must be of type array", but it's a Document/Collection HOT 2
- Implement ObjectManager::isUninitializedObject
- Add optional parameters to `nearSphere` and `near` GeoFuntions HOT 2
- Specify return type of PersistentCollection::filter and ::map HOT 1
- foreach loops breaks when takes count inside loop HOT 3
- QueryBuilder is replacing "id" by "_id" when filtering on a hash field HOT 1
- Cannot override the class metadata factory via configuration since 2.5.0 HOT 3
- Indices from sub classes always get re-created HOT 3
- The implementation of Countable on the CachingIterator is causing the UniqueEntityValidator to always fail HOT 2
- 2dsphere indexes get re-created everytime HOT 1
- Mapping validation does not validate targetDocument
- README link to API is broken HOT 1
- BC Break if the storeEmptyArray is not defined in the mapping HOT 8
- Add `dm` input option to commands that requires it
- GridFs HydratorException : Expected association field "metadata" to be of type "array", "object" received HOT 4
- Embedded Subset Pattern implementation HOT 2
- MongoDB-ODM & Spiral framework. HOT 1
- Update embed many attribute to empty array HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mongodb-odm.