GithubHelp home page GithubHelp logo

Comments (15)

epicwhale avatar epicwhale commented on June 30, 2024

Another better example is in \Doctrine\MongoDB\Query\Builder

the return types for functions like field(..), equals(..), where(..) is @return Query instead of @return Builder.

from mongodb-odm.

kriswallsmith avatar kriswallsmith commented on June 30, 2024

Would you be willing to submit a PR to fix these?

from mongodb-odm.

epicwhale avatar epicwhale commented on June 30, 2024

I'm sorry, but what does PR stand for?

from mongodb-odm.

kriswallsmith avatar kriswallsmith commented on June 30, 2024

Pull request.

No apology necessary :)

from mongodb-odm.

epicwhale avatar epicwhale commented on June 30, 2024

ha, stupid me. Should be an obvious term on git. I'm still on the SVN bandwagon, so figuring out the git mechanisms will take me a while. I'm going to try my hands around a little. But does there happen to be an easier for me to contribute towards this issue? Since I'm going to be using ODM heavily this month, I can fix any broken PHPDoc blocks.

from mongodb-odm.

kriswallsmith avatar kriswallsmith commented on June 30, 2024

Sounds like an excellent opportunity to learn some basic Git, actually. Fork the repository in GitHub, clone your fork to your computer, make the changes, commit the changes, push the changes, submit a PR.

from mongodb-odm.

epicwhale avatar epicwhale commented on June 30, 2024

Sounds good. Should I submit a PR frequently or only once I've covered a substantial amount of PHPDoc fixes?

from mongodb-odm.

kriswallsmith avatar kriswallsmith commented on June 30, 2024

One PR with everything would be awesome.

from mongodb-odm.

epicwhale avatar epicwhale commented on June 30, 2024

Ok, I'll try my best :)

p.s: closed that issue by mistake.

from mongodb-odm.

epicwhale avatar epicwhale commented on June 30, 2024

@kriswallsmith

Tell me if a fix like this would be acceptable? epicwhale/mongodb@eec4105#lib/Doctrine/MongoDB/Query/Builder.php (that belongs from the mongodb library, but just use it as an example)

I just want to make sure I'm doing the right thing and the final push will actually be accepted into the master branch.

from mongodb-odm.

epicwhale avatar epicwhale commented on June 30, 2024

I've been fixing more of it. Could you tell me if there are any objections to my PHPDoc improvements?

epicwhale@570c1da#lib/Doctrine/ODM/MongoDB/Query/Builder.php

from mongodb-odm.

kriswallsmith avatar kriswallsmith commented on June 30, 2024

Your work looks good to me.

from mongodb-odm.

epicwhale avatar epicwhale commented on June 30, 2024

Great. I'll do the same for the mongodb library as well and update you when I'm done. It's going to take a while. Any major changes to the API planned in the coming weeks? I don't want to be witnessing conflicts when I pull.

from mongodb-odm.

epicwhale avatar epicwhale commented on June 30, 2024

@kriswallsmith

The most important bits are already covered (since these will be used by end-developers). Here's the pull request: #128

from mongodb-odm.

jwage avatar jwage commented on June 30, 2024

if you want to make more changes please send a PR.

from mongodb-odm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.