Perform mapreduce without trying to find / retrieve results? about mongodb-odm

[epicwhale]

I dug into the code and discovered this. I realized the ->find() function is being called after every mapreduce. What is the thought behind it? Read my comments inline in the code below.

In _Doctrine/MongoDB/Collection.php_ - Line _135_ ( https://github.com/doctrine/mongodb/blob/master/lib/Doctrine/MongoDB/Collection.php#L375 )

<?php
    protected function doMapReduce($map, $reduce, array $out, array $query, array $options)
    {

       // ..........

        if (isset($out['inline']) && $out['inline'] === true) {
            return new ArrayIterator($result['results']);
           // ^^^ this is as expected since results are asked for inline
        }

        return $this->database->selectCollection($result['result'])->find();
        // ^^^ why are we doing this find(..) ? the user has categorically mentioned that he wants the output go to a particular collection. 
    }

Don't you think it would be better to do away with the ->find(..) all together?

[jwage]

I am not sure. what do you expect the behavior to be?

[epicwhale]

If I'm performing a MapReduce whose results are being stored in a separate collection, there's no guarantee that I want to retrieve the results later on. Sometimes, you run MapReduce's to just aggregate and keep the results for later use.

If the MapReduce does not return the result inline, I believe it should either return nothing or return the statistics of the mapreduce (time taken, emits, etc).

[jmikola]

Closing this, as we'll track it in doctrine/mongodb#95