GithubHelp home page GithubHelp logo

Comments (4)

heyvito avatar heyvito commented on September 26, 2024 2

Hey @netstx! Thank you for the suggestion!
The initial idea was to emit a single HTML file, but since we started using WASM for FTS, indeed stork is indeed a great option!
I'll take a look at this ASAP!

Once again, thank you for the suggestion! ♥️

from docuowl.

heyvito avatar heyvito commented on September 26, 2024 1

Hi there @netstx!

I discussed with other members, and we sadly determined it would be not ideal to use Stork as a dependency of Docuowl.
In order to use it, we would need to either:

a) Distribute a Stork binary together with Docuowl, which would end up with more than a single binary; or
b) Compile Stork as a cdylib and use it through a FFI. To do that, we would need to compile Stork to all platforms we are currently supporting (Darwin ARM64/x86_64, Linux ARM64/x86_64), and that would require us to maintain a build pipeline for all those platforms. Also, FFI between Rust and Go is a slippery slope, and that would require extra work in order to maintain that integration.

The search we are providing here would be just to aid people searching for contents (since it will by default avoid indexing code blocks). For all other needs and purposes, the browser native search would be enough for all use cases, specially since Docuowl emits a single HTML file. ✨

It is really sad we can't use it. Stork is an awesome project, and I really wanted to be able to use it here. :(

I hope this explains our reasoning, and please let me know in case I can provide you further information!

from docuowl.

netstx avatar netstx commented on September 26, 2024

@heyvito Glad you found it useful! I am not fluent in Go, but I'd be happy to help test this feature in the future, just mention me here and I will help where I can :)

P.S.: I guess it didn't cross my mind you could use stork with just the finished .html file isntead of the markdown files, that'd be even easier I guess!

from docuowl.

netstx avatar netstx commented on September 26, 2024

@heyvito that makes a lot of sense, nevertheless thanks for putting this much thought into my suggestion!

from docuowl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.