Comments (5)
I think we should also handle:
- merging the values onto the existing by default. If you have a
KEY=VALUE
already specified and the.env
path has aKEY=VALUE2
, we would setKEY=VALUE2
--replace
: setting this flag would completely replace all existing environment variables. This wouldn't be default, as it would impact usage of stuff like service linking (and maybe we need to overhaul that)- This should support
stdin
via a-
(dash) so you could doconfig:import $APP -
to read in env vars. This is particularly useful if the file in question is local and the command is performed via ssh, or if the file is on the host but isn't owned by the dokku user (or otherwise unreadable).
from dokku.
Hey i am have some interest working on this issue. @lasroun what format do you have in mind for the .env
file ?
from dokku.
@PapePathe i think we already import a goenv library, so whatever format that supports is probably lowest friction.
from dokku.
Great, i will look into the source code and see where i can start.
from dokku.
Can you assign the story to me please.
Also i have a couple of questions. On my fork i have the version with dokku config:import <app-name> /path/to/.env
working and go tests passing. After making sure the import file is valid, i reused the SetMany
function to apply the changes to the app's env.
How do you feel about that? Does the SetMany
supports the case of merging the values on the existing by default ?
I do not quite get the stdin
support part, but i am interested in adding support for it since it find it very useful.
Given we plan to have the --replace flag should we i using SetMany
?
I think we should also handle:
- merging the values onto the existing by default. If you have a
KEY=VALUE
already specified and the.env
path has aKEY=VALUE2
, we would setKEY=VALUE2
--replace
: setting this flag would completely replace all existing environment variables. This wouldn't be default, as it would impact usage of stuff like service linking (and maybe we need to overhaul that)- This should support
stdin
via a-
(dash) so you could doconfig:import $APP -
to read in env vars. This is particularly useful if the file in question is local and the command is performed via ssh, or if the file is on the host but isn't owned by the dokku user (or otherwise unreadable).
from dokku.
Related Issues (20)
- Dokku run fails with docker error: Conflicting options: --restart and --rm HOT 5
- Chaning ownership of storage file, Opreration not permitted HOT 8
- Issue with permissions during the deploy when using a legacy herokuish version HOT 2
- k3s plugin - add PV option
- buildpacks:set-property - odd behaviour
- Aborting a deployment of the release task fails HOT 5
- Openresty proxy: Not building `nginx.conf` and not updating `sudoers.d` with openresty varaint HOT 2
- Plugin creation doc references progrium site
- GIT_REV not set or updated with git:sync
- Deleting an app is not possible when Nginx is not running
- Send SIGTERM immediately to old containers when deploying via docker-local
- configuring Traefik healthchecks from app config HOT 1
- Add a method to force build when re-using an image with git:from-image HOT 1
- Failure injecting environment variables HOT 6
- Blue screen on deployed app HOT 1
- Ubuntu 24.04 support HOT 5
- App still running after Dokku `ps:stop` HOT 1
- Regression in dokku enter command
- Issue for new release of `gliderlabs-sigil` package HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dokku.