After Update to Kaos 2024-02-06a "E_WARNING: Undefined array key "REMOTE_USER" about dokuwiki

[fiwswe]

The code should probably use the Server class (inc/Input/Server.php) instead of accessing $_SERVER directly. That would avoid these types of exceptions. (No idea if the code would be correct when there is no $_SERVER['REMOTE_USER'] though.)

Note: I don't have an AD to test so someone else will have to create a PR, sorry.

[splitbrain]

Line in question is part of the adLDAP library:

dokuwiki/lib/plugins/authad/adLDAP/adLDAP.php

Line 698 in 9e5ebb6

if ($this->useSSO && $_SERVER['REMOTE_USER'] && $_SERVER['REMOTE_USER'] == $username && $this->adminUsername === NULL && $_SERVER['KRB5CCNAME']) {

However this line would only be triggered when using that library's useSSO config feature. The error also would only occur if the web server did not set the appropriate headers needed for Single Sign On.

Usually useSSO should not be enabled at all. For Single Sign On, the plugin's own sso config option should be enabled. SSO is then handled within the plugin and not in the library (and would use the appropriate Input wrapper as suggested by @fiwswe).

I also don't see how this should be related to Kaos at all. It might be related to a PHP upgrade or to a loss of SSO configuration at the web server level.

I will close this as this seems to be a misconfiguration of the authAD plugin (a configuration btw. that was not provided in the bug report!).

@rldml if you think that's wrong, reply with more info, detailing your configuration and SSO setup.