Get rid of clearVariables and allow object reuse about docx

[dolanmiu]

Yes you are right with clearVariables(). Could you find a class with has an implementation in clearVariables()?

Yes I think deprecating XmlUnit; and combining it into one class is a good idea.

Wow yes, I like the idea of using XmlComponent<Properties> will be much cleaner.

Regarding the JSON.parse thing, At the time it was quick and understandable to me. Will the new implantation of the formatter be easy to read? I don't mind sacrificing some efficiency for readability. Don't want to overengineer the problem.

[felipeochoa]

Almost there with the first part, but yes, I think it will be much easier to understand actually. Something like:

formatComponent(comp) {
  const ret = {};
  ret[comp.rootKey] = comp.root.map.forEach(subComp => {
    if (subComp instanceof XmlComponent)
      return formatComponent(comp);
    else  // Must be a string
      return comp
  });
  return ret;
}

(Or something like that -- I just wrote that quickly in the ocmment box)

[dolanmiu]

is it possible to have the format like the clearVariables() kind of style? I say this because then the format logic for each component can be inside the component itself, which could make it very clean. Just a thought.

Also, we should use native for-of rather than lodashes version (foreach)

[felipeochoa]

I like that idea! How about giving elements a .toXml method? We'd only have to implement it for XmlComponent and XmlAttributeComponent

[dolanmiu]

Yeah a .toXml() method is perfect. Nice and descriptive

[dolanmiu]

I am looking into the tests now, there is the jsonify() method which does JSON.parse/JSON.stringify

I am moving that out into a Utility class because its copied and pasted everywhere.

This got me thinking, surely we would need JSON.parse/JSON.stringify in the formatter as well then?

[dolanmiu]

Wow, I just saw you did this:

expect(tree).to.deep.equal({
     "w:spacing": [{_attr: {"w:before": 100}}],
});

which eliminates the need for the jsonify() method? Epic stuff

[felipeochoa]

Closed with #14